Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all references to storage.googleapis.com/kubernetes-release with dl.k8s.io #41072

Merged
merged 4 commits into from
Aug 12, 2023
Merged

Replace all references to storage.googleapis.com/kubernetes-release with dl.k8s.io #41072

merged 4 commits into from
Aug 12, 2023

Conversation

9bany
Copy link
Contributor

@9bany 9bany commented May 11, 2023

fixes: #41069

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @9bany!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/de Issues or PRs related to German language labels May 11, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/ru Issues or PRs related to Russian language language/vi Issues or PRs related to Vietnamese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 11, 2023
@netlify
Copy link

netlify bot commented May 11, 2023 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c8ac19f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/64d78d92446b090008485d94
😎 Deploy Preview https://deploy-preview-41072--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@T-Lakshmi
Copy link
Contributor

Hi @9bany,
Thanks for the PR contribution.
Seems this PR has changes to multiple languages. In general we are not supposed to submit a PR to multiple languages. I recommend you to break this up into multiple PRs, where we have a single PR per language.

@9bany
Copy link
Contributor Author

9bany commented May 11, 2023

Hi @9bany, Thanks for the PR contribution. Seems this PR has changes to multiple languages. In general we are not supposed to submit a PR to multiple languages. I recommend you to break this up into multiple PRs, where we have a single PR per language.

Let me break this up into multiple PRs, thanks @T-Lakshmi

@9bany 9bany force-pushed the fix/replace-all-references-storage-to-k8s branch from eb4eb0c to 2509c3d Compare May 11, 2023 09:32
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2023
@9bany 9bany changed the title replace all references to https://storage.googleapis.com/kubernetes-release with https://dl.k8s.io [En]replace all references to https://storage.googleapis.com/kubernetes-release with https://dl.k8s.io May 11, 2023
@9bany 9bany changed the title [En]replace all references to https://storage.googleapis.com/kubernetes-release with https://dl.k8s.io [En]replace all references to storage.googleapis.com/kubernetes-release with dl.k8s.io May 11, 2023
@9bany 9bany changed the title [En]replace all references to storage.googleapis.com/kubernetes-release with dl.k8s.io [En] replace all references to storage.googleapis.com/kubernetes-release with dl.k8s.io May 11, 2023
@dipesh-rawat
Copy link
Member

/remove-language ja
/remove-language ko
/remove-language de
/remove-language fr
/remove-language pt
/remove-language ru
/remove-language vi
/remove-language zh

@k8s-ci-robot k8s-ci-robot removed language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/de Issues or PRs related to German language language/fr Issues or PRs related to French language labels May 11, 2023
@k8s-ci-robot k8s-ci-robot removed the language/id Issues or PRs related to Indonesian language label May 11, 2023
dipesh-rawat
dipesh-rawat reviewed May 12, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we do not make changes to blog posts that are more than a year old. However, this PR proposes beneficial modifications regarding the use of dl.k8s.io as the kubernetes release artifact download location. I'll lgtm for now and ask a blog approver to review it.
/lgtm

@kubernetes/sig-docs-blog-owners , Please take a look.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2023
@9bany
Copy link
Contributor Author

9bany commented May 14, 2023

Any problems in this pull request ? @-maintainers @-reviewers

@9bany 9bany force-pushed the fix/replace-all-references-storage-to-k8s branch from 83c4f28 to 02f092e Compare May 23, 2023 11:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dipesh-rawat May 23, 2023 11:48
dipesh-rawat
dipesh-rawat reviewed May 23, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. (Previous comment: #41072 (review))

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
sftim
sftim reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. These changes won't work without modifications.

content/en/blog/_posts/2019-03-28-running-kubernetes-locally-on-linux-with-minikube.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2015-12-00-Creating-Raspberry-Pi-Cluster-Running.md Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented May 23, 2023

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dipesh-rawat May 23, 2023 15:35
9bany and others added 2 commits May 23, 2023 23:38
@9bany @sftim
add -L
5c4d0a5 
Co-authored-by: Tim Bannister <[email protected]>
@9bany @sftim
add -L
edb8066 
Co-authored-by: Tim Bannister <[email protected]>
@dipesh-rawat dipesh-rawat mentioned this pull request Jun 3, 2023
Closed
@sftim
Copy link
Contributor

sftim commented Jul 23, 2023

/retitle Replace all references to storage.googleapis.com/kubernetes-release with dl.k8s.io

@k8s-ci-robot k8s-ci-robot changed the title [En] replace all references to storage.googleapis.com/kubernetes-release with dl.k8s.io Replace all references to storage.googleapis.com/kubernetes-release with dl.k8s.io Jul 23, 2023
sftim
sftim reviewed Aug 12, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a560e4fd2ec4162c6937de2c3cf39d3c343e24c0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 68999b9 into kubernetes:main Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@ariscahyadi ariscahyadi Awaiting requested review from ariscahyadi

@jmyung jmyung Awaiting requested review from jmyung

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

Assignees

@dipesh-rawat dipesh-rawat

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace all references to https://storage.googleapis.com/kubernetes-release with https://dl.k8s.io
5 participants
@9bany @k8s-ci-robot @T-Lakshmi @dipesh-rawat @sftim