Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-cn] Translate API reference daemonset-v1 #34985

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Conversation

sarazqy
Copy link
Contributor

@sarazqy sarazqy commented Jul 13, 2022

translate content/zh-cn/docs/reference/kubernetes-api/workload-resources/daemon-set-v1.md
into Chinese

Fixes #34733

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 13, 2022
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot requested a review from ydFu July 13, 2022 12:28
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 13, 2022
@windsonsea
Copy link
Member

Need wait for a dependency to merge. FYI:

ERROR 2022/07/13 12:29:44 [zh-cn] REF_NOT_FOUND: Ref "../workload-resources/pod-template-v1": 

Copy link
Contributor Author

@sarazqy sarazqy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks to review again

@tengqm
Copy link
Contributor

tengqm commented Jul 14, 2022

/retitle [zh-cn] Translate API reference daemonset-v1

@k8s-ci-robot k8s-ci-robot changed the title translate content/zh-cn/docs/reference/kubernetes-api/workload-resources/daemon-set-v1.md into Chinese [zh-cn] Translate API reference daemonset-v1 Jul 14, 2022
content/zh-cn/docs/reference/kubernetes-api/workload-resources/daemon-set-v1.md
into Chinese
@tengqm
Copy link
Contributor

tengqm commented Jul 19, 2022

/approve

This looks ready to merge once the dependency is resolved.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@Sea-n
Copy link
Member

Sea-n commented Jul 20, 2022

Wait for pod-template-v1.md.

@Sea-n
Copy link
Member

Sea-n commented Jul 21, 2022

Hey @sarazqy,

Please avoid use fixes #xxx in PR description for umbrella issues.
We can use related: #xxx or part of: #xxx so that the umbrella issue would not be closed unintentionally.

@sarazqy
Copy link
Contributor Author

sarazqy commented Jul 21, 2022

Hey @sarazqy,

Please avoid use fixes #xxx in PR description for umbrella issues. We can use related: #xxx or part of: #xxx so that the umbrella issue would not be closed unintentionally.

----I wrote it as you suggested earlier
@Sea-n

Sea-n commented on 15 Jun
FYI, you can use Fixes #34193 in your PR description, so that the bot will automatically close this issue when it's done.

小技巧:可以在 PR 描述裡面加上一行文字寫上 Fixes #34193,這樣被 merge 時才會自動關閉相應 issue

@Sea-n
Copy link
Member

Sea-n commented Jul 21, 2022

Yeah, it's a little bit tricky.
For PR that fixes the entire issue, we would use fixes #xxx to close it automatically.

But this PR is part of an umbrella issue, this PR just done part of the huge job.
So we don't want the issue to be closed while others are working on part of it.

@tengqm
Copy link
Contributor

tengqm commented Jul 25, 2022

Please rebase this onto 'main' branch where 'pod-v1.md' has been translated.

@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2022

Please rebase this onto 'main' branch where 'pod-template-v1.md' has been translated.

@netlify
Copy link

netlify bot commented Jul 29, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fcb6de6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62e38cbb96340800083dba21
😎 Deploy Preview https://deploy-preview-34985--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tengqm
Copy link
Contributor

tengqm commented Jul 29, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2d8c4165994f0dfcf880947b8972ad7a9ff8bbec

@k8s-ci-robot k8s-ci-robot merged commit 7bec728 into kubernetes:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zh-cn][Umbrella] API reference pages to sync.
6 participants