Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- [zh] Translate pod-template-v1.md #34319

Closed
wants to merge 1 commit into from
Closed

- [zh] Translate pod-template-v1.md #34319

wants to merge 1 commit into from

Conversation

qlijin
Copy link
Member

@qlijin qlijin commented Jun 16, 2022

fix issue #34270

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign howieyuen after the PR has been reviewed.
You can assign the PR to them by writing /assign @howieyuen in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from chenxuc June 16, 2022 04:50
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Jun 16, 2022
@k8s-ci-robot k8s-ci-robot requested a review from SataQiu June 16, 2022 04:50
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jun 16, 2022
Sea-n
Sea-n reviewed Jun 16, 2022
View reviewed changes
Copy link
Member

@Sea-n Sea-n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to Netlify deploy log.

content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md
-->
标准对象的元数据。 更多信息： https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata

- **spec** (<a href="{{< ref "../workload-resources/pod-v1#PodSpec" >}}">PodSpec</a>)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to translate this page first, or the build won't be success.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for #34294.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. This page's build relies on other pages

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs/reference/kubernetes-api/workload-resources/pod-v1.md also relies:
docs/reference/kubernetes-api/config-and-storage-resources/volume.md
docs/reference/kubernetes-api/config-and-storage-resources/persistent-volume-claim-v1.md

these two file is in ##34158

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I need more time to handle config-and-storage-resources/volume.md that is relatively big with nearly 6000 words.

windsonsea
windsonsea suggested changes Jun 19, 2022
View reviewed changes
Copy link
Member

@windsonsea windsonsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only viewed a beginging part. May need much change and wait for other files to merge.

content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated
description: "PodTemplate 描述了一种创建预定义 pod 副本的模板。"
title: "PodTemplate"
weight: 2
auto_generated: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line 10

content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Show resolved Hide resolved
@qlijin
Copy link
Member Author

qlijin commented Jun 22, 2022

ok. There will be a new commit

@tengqm
Copy link
Contributor

tengqm commented Jun 24, 2022

Which file is required by this one?

@qlijin
Copy link
Member Author

qlijin commented Jun 24, 2022 •
edited
Loading

Which file is required by this one?

Wait for volume.md and pod-v1.md.
persistent-volume-claim-v1.md is done.

zhangxyjlu
zhangxyjlu reviewed Jun 27, 2022
View reviewed changes
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated

name of the PodTemplate
-->
- **name** (**位于路径中**): string,必需
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **name** (**位于路径中**): string,必需
- **name** (**路径参数**): string,必需

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他地方也排查一下

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
tengqm
tengqm reviewed Jun 28, 2022
View reviewed changes
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
content/zh-cn/docs/reference/kubernetes-api/workload-resources/pod-template-v1.md Outdated Show resolved Hide resolved
@qlijin
Copy link
Member Author

qlijin commented Jun 30, 2022 •
edited
Loading

已按照建议修改，但还是依赖pod-v1.md #34630
请注意是pod-v1.md 不是job-v1.md

@tengqm tengqm mentioned this pull request Jun 30, 2022
Closed
32 tasks
@sarazqy sarazqy mentioned this pull request Jul 1, 2022
Merged
@yaolixin-creater yaolixin-creater mentioned this pull request Jul 7, 2022
Merged
This was referenced Jul 9, 2022
Merged
Merged
Merged
@tengqm
Copy link
Contributor

tengqm commented Jul 11, 2022

已按照建议修改，但还是依赖pod-v1.md #34630 请注意是pod-v1.md 不是job-v1.md

This one depends on the pod-v1.md file, which was claimed by @ydFu ten days ago. We haven't got a draft to review.
There is no dependency on 34630.

@Sea-n
Copy link
Member

Sea-n commented Jul 20, 2022

Wait for pod-v1.md.

@Sea-n Sea-n mentioned this pull request Jul 20, 2022
Merged
@tengqm
Copy link
Contributor

tengqm commented Jul 25, 2022

Please rebase this onto 'main' branch where 'pod-v1.md' has been translated.

@tengqm
Copy link
Contributor

tengqm commented Jul 26, 2022

Since this is blocking many other API references, I'm gonna take it over and propose a new PR.
/close

@k8s-ci-robot
Copy link
Contributor

@tengqm: Closed this PR.

In response to this:

Since this is blocking many other API references, I'm gonna take it over and propose a new PR.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tengqm tengqm mentioned this pull request Jul 26, 2022
Merged
@qlijin
Copy link
Member Author

qlijin commented Jul 28, 2022

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangxyjlu zhangxyjlu zhangxyjlu left review comments

@Sea-n Sea-n Sea-n left review comments

@tengqm tengqm tengqm left review comments

@windsonsea windsonsea windsonsea requested changes

@chenxuc chenxuc Awaiting requested review from chenxuc

@SataQiu SataQiu Awaiting requested review from SataQiu

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qlijin @k8s-ci-robot @tengqm @Sea-n @windsonsea @zhangxyjlu