Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zh-cn] update zh-cn docs to use recommended labels #34851

Conversation

therealdwright
Copy link
Contributor

Updates docs to use Kubernetes recommended labels as outlined in the documentation.

Initially included in #34116 but broken out into a separate PR per #34116 (comment) from @Sea-n

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign sataqiu after the PR has been reviewed.
You can assign the PR to them by writing /assign @sataqiu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from chenxuc July 6, 2022 17:28
@k8s-ci-robot k8s-ci-robot added the language/zh Issues or PRs related to Chinese language label Jul 6, 2022
@k8s-ci-robot k8s-ci-robot requested a review from SataQiu July 6, 2022 17:28
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jul 6, 2022
@therealdwright therealdwright force-pushed the zn-ch-update-docs-labels branch from 9695420 to ffc2120 Compare July 6, 2022 17:29
@therealdwright therealdwright changed the title [zh-cn] update es docs to use recommended labels [zh-cn] update zh-cn docs to use recommended labels Jul 6, 2022
@netlify
Copy link

netlify bot commented Jul 6, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 9695420
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62c5c637f8318a000954a62c
😎 Deploy Preview https://deploy-preview-34851--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jul 6, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit ffc2120
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62c5c6719058c3000887816b
😎 Deploy Preview https://deploy-preview-34851--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tengqm
Copy link
Contributor

tengqm commented Jul 8, 2022

/hold
This PR is not supposed to be merged. We treat each page an atomic unit for any updates where each update has to be a full resync of the upstream page, or else we cannot track upstream changes for Chinese localization.

However, we can use this PR as a reference when one of the pages need to be sync'ed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2022
@k8s-ci-robot
Copy link
Contributor

@therealdwright: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Sea-n
Copy link
Member

Sea-n commented Aug 3, 2022

Thanks @kinzhi and @windsonsea for updating and re-sync all those pages. 😊

@Sea-n
Copy link
Member

Sea-n commented Aug 3, 2022

As all files are synced, we are closing this PR/issue now.
/close

@k8s-ci-robot
Copy link
Contributor

@Sea-n: Closed this PR.

In response to this:

As all files are synced, we are closing this PR/issue now.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/zh Issues or PRs related to Chinese language needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants