Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs labels #34116

Merged
merged 1 commit into from
Jul 22, 2022
Merged

update docs labels #34116

merged 1 commit into from
Jul 22, 2022

Conversation

therealdwright
Copy link
Contributor

@therealdwright therealdwright commented Jun 2, 2022 •
edited
Loading

Updates docs to use kubernetes recommended labels
as outlined in the documentation.

  • [en] update en docs to use recommended labels

Closes #34115

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 2, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 2, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @therealdwright!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language language/es Issues or PRs related to Spanish language language/fr Issues or PRs related to French language labels Jun 2, 2022
@k8s-ci-robot k8s-ci-robot added language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/uk Issues or PRs related to Ukrainian language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 2, 2022
@netlify
Copy link

netlify bot commented Jun 2, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit f9ebc90
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62cc45bffaf1ab00087186e8
😎 Deploy Preview https://deploy-preview-34116--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bradtopol
Copy link
Contributor

Assigning @kbarnard10 since this affects so much blog content
/assign @kbarnard10

joshdk
joshdk approved these changes Jun 2, 2022
View reviewed changes
Copy link

@joshdk joshdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@Sea-n
Copy link
Member

Sea-n commented Jun 3, 2022

Hey @therealdwright,

Please limit this PR to only change content/en, and open different PR for each language (or leave it to other contributor).

Feel free to /unhold yourself once it's done.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2022
@therealdwright
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 3, 2022
@k8s-ci-robot k8s-ci-robot requested a review from tengqm June 7, 2022 21:11
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2022
@therealdwright therealdwright requested a review from sftim June 7, 2022 21:12
sftim
sftim requested changes Jun 12, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-area blog

There are some merge conflicts that needed resolving manually but haven't been. @therealdwright, please fix those.

/hold
OK to unhold once the merge conflict byproducts are gone.

content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
content/en/docs/concepts/services-networking/dual-stack.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed area/blog Issues or PRs related to the Kubernetes Blog subproject labels Jun 12, 2022
@therealdwright
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 12, 2022
@therealdwright therealdwright requested a review from sftim June 12, 2022 21:40
@therealdwright therealdwright mentioned this pull request Jun 12, 2022
Merged
@tengqm
Copy link
Contributor

tengqm commented Jun 20, 2022

/hold cancel
Conflicts resolved.

@therealdwright
Copy link
Contributor Author

@sftim is this something that there is any interest in merging?

@therealdwright therealdwright mentioned this pull request Jul 6, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2022
Sea-n
Sea-n reviewed Jul 22, 2022
View reviewed changes
Copy link
Member

@Sea-n Sea-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patient. The changes looks good to me now.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 91bdb6c0ff8aa183a2da2640f2dc4b023723e5d5

@tengqm
Copy link
Contributor

tengqm commented Jul 22, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshdk, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 46aae33 into kubernetes:main Jul 22, 2022
@therealdwright therealdwright deleted the update-docs-labels branch July 22, 2022 03:55
This was referenced Aug 8, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sea-n Sea-n Sea-n left review comments

@joshdk joshdk joshdk approved these changes

@bridgetkromhout bridgetkromhout Awaiting requested review from bridgetkromhout

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

@tengqm tengqm Awaiting requested review from tengqm

@sftim sftim Awaiting requested review from sftim

Assignees

@tengqm tengqm

@savitharaghunathan savitharaghunathan

@Sea-n Sea-n

@kbarnard10 kbarnard10

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs to use recommended labels
9 participants
@therealdwright @k8s-ci-robot @bradtopol @Sea-n @tengqm @joshdk @sftim @savitharaghunathan @kbarnard10