Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manifest for example Job to calculate π #34475

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

mcmattco
Copy link
Contributor

The perl command in the job example yaml file fails at image version >5.34:

> docker run -it perl:5.36 bash
...
root@783a8ea24899:/# perl -Mbignum=bpi -wle "print bpi(2000)"
Can't use an undefined value as an ARRAY reference at /usr/local/lib/perl5/5.36.0/Math/BigInt/Calc.pm line 1049.```

> docker run -it perl:5.35 bash
...
docker: Error response from daemon: manifest for perl:5.35 not found: manifest unknown: manifest unknown.```

> docker run -it perl:5.34 bash
...
root@d4efc70c15b5:/# perl -Mbignum=bpi -wle "print bpi(2000)"
3.141592653589793238...

The perl command fails at image version >5.34:

```
> docker run -it perl:5.36 bash
...
root@783a8ea24899:/# perl -Mbignum=bpi -wle "print bpi(2000)"
Can't use an undefined value as an ARRAY reference at /usr/local/lib/perl5/5.36.0/Math/BigInt/Calc.pm line 1049.```

> docker run -it perl:5.35 bash
...
docker: Error response from daemon: manifest for perl:5.35 not found: manifest unknown: manifest unknown.```

> docker run -it perl:5.34 bash
...
root@d4efc70c15b5:/# perl -Mbignum=bpi -wle "print bpi(2000)"
3.141592653589793238...
```
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 22, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mcmattco / name: Matt McClure (1ee7c15)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 22, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @mcmattco!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot requested a review from onlydole June 22, 2022 19:23
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 22, 2022
@netlify
Copy link

netlify bot commented Jun 22, 2022

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1ee7c15
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62b36c34804b4400080c3ede
😎 Deploy Preview https://deploy-preview-34475--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Sea-n
Copy link
Member

Sea-n commented Jun 23, 2022

Thanks for proposing the fix!

But there is someone already made PR #34070 to fix the root cause, please take a look.

@sftim
Copy link
Contributor

sftim commented Jun 23, 2022

I like this fix better: pinning the container image constrains what gets run.

/retitle Fix manifest for example Job to calculate π

@k8s-ci-robot k8s-ci-robot changed the title Update job example yaml Fix manifest for example Job to calculate π Jun 23, 2022
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix makes sense to me.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 38dd63294e6d85e55c0ca95692ba9e3c54f2ddb3

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit 49ce07f into kubernetes:main Jun 23, 2022
@mcmattco mcmattco deleted the patch-1 branch June 23, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants