lates version of perl fails with the example code, need to use v5.34.0 #34414

mhus · 2022-06-20T07:19:55Z

I tried the example and it is no more working. Perl will not process pi with an error. Perl until v5.34.0 will support the command. This fix will do for now but you should use another example working with the actual version of perl.

linux-foundation-easycla · 2022-06-20T07:19:59Z

The committers listed above are authorized under a signed CLA.

✅ login: mhus / name: Mike Hummel (adf7f85)

k8s-ci-robot · 2022-06-20T07:20:03Z

Welcome @mhus!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

netlify · 2022-06-20T07:31:54Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`06f8d88`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/62ce6794c6f31b00083dfb35
😎 Deploy Preview	https://deploy-preview-34414--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mhus · 2022-06-20T07:40:58Z

Found an issue for this topic #34073

mhus · 2022-06-20T10:05:20Z

/easycla

JohnTitor · 2022-06-21T22:40:31Z

I've already opened #34070 to avoid the root issue.

mhus · 2022-06-24T19:46:32Z

Hi, I can't get the 'lgtm' label. Don't know why... any ideas?

jihoon-seo · 2022-06-25T23:20:01Z

/lgtm

Refs:

This PR closes

jihoon-seo · 2022-06-25T23:31:49Z

@mhus Could you replace image: perl:5.34 with image: perl:5.34.0 in content/en/examples/controllers/job.yaml as well,
in this PR?
(To do this, you might need to rebase with the latest main.)

It's for consistency, and to pin the container image version more specifically.
(Currently 5.34 equals to 5.34.1,
so following the steps in https://kubernetes.io/docs/concepts/workloads/controllers/job/ will lead to pull two different versions of the perl container image.)

/lgtm cancel

mhus · 2022-06-29T10:33:57Z

looks like it's done

kbhawkey · 2022-07-09T02:26:44Z

Preview:
https://deploy-preview-34414--kubernetes-io-main-staging.netlify.app/docs/concepts/workloads/controllers/job/#running-an-example-job

kbhawkey · 2022-07-09T02:41:16Z

@mhus , The changes look good.
If you have time, could you also update the example file (content/en/examples/controllers/job.yaml) to define the image as perl:5.34.0? The example file currently uses perl:5.34.
Thanks.

mhus · 2022-07-11T07:15:55Z

Something in the preview is wrong. In my pull request is in line (it's not an include)

43 kubectl apply -f https://kubernetes.io/examples/controllers/job.yaml

In the preview is shown the full source code from job.yaml - and it not includes the perl version.

Sorry: Line 38 {{< codenew file="controllers/job.yaml" >}} includes the file. I will fix it too.

jihoon-seo · 2022-07-14T02:52:09Z

/label tide/merge-method-squash

content/en/examples/controllers/job.yaml

mhus

Looks final now.

kbhawkey · 2022-07-19T12:43:41Z

/approve

soltysh

/lgtm

k8s-ci-robot · 2022-07-21T17:22:52Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kbhawkey, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~content/en/OWNERS~~ [kbhawkey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2022-07-21T17:22:53Z

LGTM label has been added.

Git tree hash: 2efba5a06e936163463f8f2edcea6e5bc0e84568

lates version of perl fails with the example code, need to use v5.34.0

adf7f85

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 20, 2022

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Jun 20, 2022

k8s-ci-robot requested review from natalisucks and soltysh June 20, 2022 07:20

k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 20, 2022

Shubham82 mentioned this pull request Jun 21, 2022

Issue with k8s.io/docs/concepts/workloads/controllers/job/ #34433

Closed

jihoon-seo mentioned this pull request Jun 25, 2022

Failed to Running an example Job in kubernetes document #34073

Closed

k8s-ci-robot assigned jihoon-seo Jun 25, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2022

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2022

k8s-ci-robot requested a review from jihoon-seo June 25, 2022 23:32

fix perl version in example job.yaml, is not working with actual latest

a367ff9

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2022

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2022

Merge branch 'main' into patch-1

06f8d88

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2022

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 14, 2022

kbhawkey reviewed Jul 16, 2022

View reviewed changes

content/en/examples/controllers/job.yaml Show resolved Hide resolved

mhus commented Jul 18, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022

soltysh approved these changes Jul 21, 2022

View reviewed changes

k8s-ci-robot assigned soltysh Jul 21, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2022

k8s-ci-robot merged commit a15cc47 into kubernetes:main Jul 21, 2022

ysam12345 mentioned this pull request Jul 27, 2022

fix missing quotation marks in job examples #35028

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lates version of perl fails with the example code, need to use v5.34.0 #34414

lates version of perl fails with the example code, need to use v5.34.0 #34414

mhus commented Jun 20, 2022

linux-foundation-easycla bot commented Jun 20, 2022 •

edited

Loading

k8s-ci-robot commented Jun 20, 2022

netlify bot commented Jun 20, 2022 •

edited

Loading

mhus commented Jun 20, 2022

mhus commented Jun 20, 2022

JohnTitor commented Jun 21, 2022

mhus commented Jun 24, 2022

jihoon-seo commented Jun 25, 2022 •

edited

Loading

jihoon-seo commented Jun 25, 2022 •

edited

Loading

mhus commented Jun 29, 2022

kbhawkey commented Jul 9, 2022

kbhawkey commented Jul 9, 2022

mhus commented Jul 11, 2022 •

edited

Loading

jihoon-seo commented Jul 14, 2022

mhus left a comment

kbhawkey commented Jul 19, 2022

soltysh left a comment

k8s-ci-robot commented Jul 21, 2022

k8s-ci-robot commented Jul 21, 2022

lates version of perl fails with the example code, need to use v5.34.0 #34414

lates version of perl fails with the example code, need to use v5.34.0 #34414

Conversation

mhus commented Jun 20, 2022

linux-foundation-easycla bot commented Jun 20, 2022 • edited Loading

k8s-ci-robot commented Jun 20, 2022

netlify bot commented Jun 20, 2022 • edited Loading

✅ Pull request preview available for checking

mhus commented Jun 20, 2022

mhus commented Jun 20, 2022

JohnTitor commented Jun 21, 2022

mhus commented Jun 24, 2022

jihoon-seo commented Jun 25, 2022 • edited Loading

jihoon-seo commented Jun 25, 2022 • edited Loading

mhus commented Jun 29, 2022

kbhawkey commented Jul 9, 2022

kbhawkey commented Jul 9, 2022

mhus commented Jul 11, 2022 • edited Loading

jihoon-seo commented Jul 14, 2022

mhus left a comment

Choose a reason for hiding this comment

kbhawkey commented Jul 19, 2022

soltysh left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 21, 2022

k8s-ci-robot commented Jul 21, 2022

linux-foundation-easycla bot commented Jun 20, 2022 •

edited

Loading

netlify bot commented Jun 20, 2022 •

edited

Loading

jihoon-seo commented Jun 25, 2022 •

edited

Loading

jihoon-seo commented Jun 25, 2022 •

edited

Loading

mhus commented Jul 11, 2022 •

edited

Loading