Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh] Resync concepts/services-networking/ingress-controllers.md #26031

Merged
merged 1 commit into from
Jan 16, 2021
Merged

[zh] Resync concepts/services-networking/ingress-controllers.md #26031

merged 1 commit into from
Jan 16, 2021

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jan 10, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2021
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2021
@netlify
Copy link

netlify bot commented Jan 10, 2021

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: a88a704

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5ffabf9e61c9a0000839d3b7

😎 Browse the preview: https://deploy-preview-26031--kubernetes-io-master-staging.netlify.app

@tengqm
Copy link
Contributor Author

tengqm commented Jan 11, 2021

warning:
#26022 is updating the upstream at the moment.

@tengqm
Copy link
Contributor Author

tengqm commented Jan 11, 2021

Warning:
#25972 is coming in as well.

tanjunchen
tanjunchen reviewed Jan 16, 2021
View reviewed changes
Copy link
Member

@tanjunchen tanjunchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8fd5159f9f1ac3e5f5133db6d098dae5dbde3f9b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tanjunchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit e59141c into kubernetes:master Jan 16, 2021
@tengqm tengqm deleted the zh-sync-ingress-ctrl branch April 22, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanjunchen tanjunchen tanjunchen left review comments

@idealhack idealhack Awaiting requested review from idealhack

@pigletfly pigletfly Awaiting requested review from pigletfly

Assignees

@tanjunchen tanjunchen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/zh Issues or PRs related to Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tengqm @k8s-ci-robot @tanjunchen