Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EnRoute as one of the Ingress Controller API Gateway Options #25972

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Add EnRoute as one of the Ingress Controller API Gateway Options #25972

merged 2 commits into from
Jan 30, 2021

Conversation

chintan8saaras
Copy link
Contributor

EnRoute is an actively maintained API Gateway Ingress controller built on Envoy Proxy. It is an OSS project that includes support for advanced rate-limiting in the community edition.

@chintan8saaras
Add EnRoute as an option
9c94fb0 
EnRoute is an actively maintained API Gateway Ingress controller built on [Envoy Proxy](https://envoyproxy.io/community.html). It is an [OSS project](https://github.com/saarasio/enroute) that includes support for advanced rate-limiting in the [community edition](https://getenroute.io/features).
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 6, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @chintan8saaras!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 6, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 6, 2021
@chintan8saaras
Copy link
Contributor Author

Signed the Contributor License Agreement (CLA).

@netlify
Copy link

netlify bot commented Jan 6, 2021 •
edited
Loading

✔️ Deploy preview for kubernetes-io-master-staging ready!

🔨 Explore the source changes: a0b3e72

🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5ff891926be58a00089a6783

😎 Browse the preview: https://deploy-preview-25972--kubernetes-io-master-staging.netlify.app

@chintan8saaras
Copy link
Contributor Author

/check-cla

@chintan8saaras chintan8saaras changed the title Add EnRoute as an option Add EnRoute as one of the Ingress Controller API Gateway Options Jan 6, 2021
@chintan8saaras
Copy link
Contributor Author

/check-cla

@chintan8saaras
Copy link
Contributor Author

I signed it

@sftim
Copy link
Contributor

sftim commented Jan 6, 2021

Hi @chintan8saaras

Can you make sure that the commits in this PR are from an email address that GitHub recognizes as you? This also must be the same email address that the CNCF identifies you with as a CLA signatory.

@chintan8saaras
Copy link
Contributor Author

Thank you @sftim ! I verified this after your message. One observation is that github notifications for this PR and the CNCF signature confirmation were received on the same email address (github-id -at- saaras.io). Thanks !

@chintan8saaras
Copy link
Contributor Author

/check-cla

@chintan8saaras
Copy link
Contributor Author

Updated organizer as a contributing employee. Trying again with cla check

@chintan8saaras
Copy link
Contributor Author

/check-cla

@chintan8saaras
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 6, 2021
@chintan8saaras
Copy link
Contributor Author

@sftim looks like adding the PR github account identity to the cncf signing account does the trick. Thanks !

sftim
sftim reviewed Jan 7, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to word this more in line with existing entries; I suggested an example.

content/en/docs/concepts/services-networking/ingress-controllers.md Outdated Show resolved Hide resolved
@bradtopol
Copy link
Contributor

Assigning @sftim since he is already engaged on this.
/assign @sftim

@chintan8saaras
Copy link
Contributor Author

/assign @sftim

@tengqm tengqm mentioned this pull request Jan 11, 2021
Merged
@chintan8saaras
Copy link
Contributor Author

Hi @sftim , Let me know if you need me to make any more changes. I have reworded it according to what you suggested with a small change as we discussed. Also pushed a commit, lmk if it doesn't look right. Thanks !

@chintan8saaras
Copy link
Contributor Author

ping @sftim @bradtopol

@kbhawkey
Copy link
Contributor

Page preview:
https://deploy-preview-25972--kubernetes-io-master-staging.netlify.app/docs/concepts/services-networking/ingress-controllers/#additional-controllers

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f375e5fe4f9954b29395feaee4b84e771d52715f

@sftim
Copy link
Contributor

sftim commented Jan 30, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit c6a2add into kubernetes:master Jan 30, 2021
ydFu added a commit to ydFu/website that referenced this pull request Jan 31, 2021
@ydFu
[zh] Sync concepts pages for ingress-controllers.md
adbf668 
Add EnRoute as one of the Ingress Controller API Gateway Options kubernetes#25972

Signed-off-by: ydFu <[email protected]>
@ydFu ydFu mentioned this pull request Jan 31, 2021
Merged
Brian-Kwon pushed a commit to Brian-Kwon/website that referenced this pull request Feb 4, 2021
@ydFu @Brian-Kwon
[zh] Sync concepts pages for ingress-controllers.md
ae09f5c 
Add EnRoute as one of the Ingress Controller API Gateway Options kubernetes#25972

Signed-off-by: ydFu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@celestehorgan celestehorgan Awaiting requested review from celestehorgan

@kbarnard10 kbarnard10 Awaiting requested review from kbarnard10

Assignees

@kbhawkey kbhawkey

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chintan8saaras @k8s-ci-robot @sftim @bradtopol @kbhawkey