Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description in qos-pod-4.yaml #25904

Closed
wants to merge 1 commit into from
Closed

Add description in qos-pod-4.yaml #25904

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions content/en/examples/pods/qos/qos-pod-4.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ metadata:
namespace: qos-example
spec:
containers:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the added comments make sense. Maybe an existing member can comment for cofirmation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR already has an LGTM. With another LGTM I can approve it; I would like a second review from a Kubernetes member before this merges.

Copy link
Member Author

@ydFu ydFu Jan 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @sftim
l thinked this PR be reviewed from other Kubernetes member(@Aut0R3V),
Thanks for your help.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure if we need a comment about the limit provided to the memory since it’s already defined on the manifest though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it’s lgtm

# The first container specifies a memory request of 200 MiB.
- name: qos-demo-4-ctr-1
image: nginx
resources:
requests:
memory: "200Mi"

# The second container does not specify any requests or limits.
- name: qos-demo-4-ctr-2
image: redis