-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description in qos-pod-4.yaml #25904
Conversation
…make it easy to read. Signed-off-by: ydFu <[email protected]>
✔️ Deploy preview for kubernetes-io-master-staging ready! 🔨 Explore the source changes: e6799c5 🔍 Inspect the deploy logs: https://app.netlify.com/sites/kubernetes-io-master-staging/deploys/5fef100247a2a9000ade5a97 😎 Browse the preview: https://deploy-preview-25904--kubernetes-io-master-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d4396ef200ed5d7c9dda347b9e11a8b97bfe0c38
|
@sftim |
/assign @zparnold |
@@ -5,12 +5,12 @@ metadata: | |||
namespace: qos-example | |||
spec: | |||
containers: | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the added comments make sense. Maybe an existing member can comment for cofirmation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR already has an LGTM. With another LGTM I can approve it; I would like a second review from a Kubernetes member before this merges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure if we need a comment about the limit provided to the memory since it’s already defined on the manifest though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise it’s lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Aut0R3V The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ydFu: GitHub didn't allow me to request PR reviews from the following users: Aut0R3V. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @tengqm |
@ydFu TBH, I don't think we really need comments like these. The manifest is already straightforward. |
Thanks for your guidance. |
@ydFu All the YAML manifests under the |
@tengqm |
Add description that distinguish between container-1 and container-2 make it easy to read.
Signed-off-by: ydFu [email protected]