Add content/es/docs/concepts/overview/components.md #22259
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
language/es
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit a4390f1 https://deploy-preview-22259--kubernetes-io-master-staging.netlify.app |
raelga
force-pushed
the
es-overview-components
branch
2 times, most recently
from
805c0f9 to
cbbaf72
Compare
raelga
force-pushed
the
es-overview-components
branch
3 times, most recently
from
90b3a1c to
891b912
Compare
|
@raelga that was just an informal review - I'm confident you understood what fixes I was suggesting |
|
/cc @emedina :D |
raelga
force-pushed
the
es-overview-components
branch
from
7d25989 to
2a396be
Compare
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
|
If you did have time to rebase this further @raelga you could probably cut it from 16 commits down to 1 |
raelga
force-pushed
the
es-overview-components
branch
from
2a396be to
16f864d
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
raelga
force-pushed
the
es-overview-components
branch
from
16f864d to
f3b2172
Compare
I reduced the number of commits, anyhow, this will be squashed on merge. |
Add controller glossary term Add etcd glossary term Add kube-apiserver glossary term Add kube-controller-manager glossary term Add kube-sccheduler glossary term Add namespace glossary term
Co-authored-by: Enrique Medina Montenegro <[email protected]>
raelga
force-pushed
the
es-overview-components
branch
from
f3b2172 to
a4390f1
Compare
sftim
added
the
tide/merge-method-squash
|
I've marked this for squash on merge (the default is now merge-method-merge). |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Good to know, thanks! I like to keep some minimum number of logical commits to make easier reviewing and working on the documentation. I will add the label on the next PRs!
Thanks @emedina ! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raelga The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
One more thing on squashing @raelga - if the commits are squashed down as much as you think they can go and each commit message describes a logically separate change, then there's no need to select a squash merge method. |
|
Looking back at this, it's fine, I'd be happy to see that sequence of commits go in as a merge. When I saw more than 30 though I was thinking it could definitely use a tidying. |
|
The 30 commit spike was just the result of accepting all @emedina suggestions. It makes easier to accept all the suggestions using the GitHub PR discussion interface and then squash them into a single accepted suggestions commit coauthored by the reviewer. But you catch me in the middle of the process :P. |
* Add content/es/docs/concepts/overview/components.md * Apply kubernetes#14678 suggestions * Replace content_template with content_type * Remove capture shortcode * Add missing glossary terms Add controller glossary term Add etcd glossary term Add kube-apiserver glossary term Add kube-controller-manager glossary term Add kube-sccheduler glossary term Add namespace glossary term * Remove `master` references * Apply emedina suggestions Co-authored-by: Enrique Medina Montenegro <[email protected]> Co-authored-by: Jose Miguel Parrella <[email protected]> Co-authored-by: Enrique Medina Montenegro <[email protected]>
Follows the awesome @bureado work, applies the pending suggestions from #14678 and adds all the missing glossary terms that were causing the build failure.