-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconcile the minikube install page with best practices #20717
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit 046216e https://deploy-preview-20717--kubernetes-io-master-staging.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tstromberg here's some feedback - I hope it's useful.
I'm happy to take another look when you're ready for that.
/sig minikube |
@sftim: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @sftim |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@tstromberg, Changes look okay. |
Do you have any suggestions? From my vantage point it seems self explanatory given the surrounding context, both from the documentation and the command output.
This is just an installation doc, the guide for managing your cluster should be captured by the "whatsnext" link (which I also intend to update once this doc is approved) |
@tstromberg ,
minikube will automatically select an appropriate driver, but will mention alternatives if available.
To stop your cluster, run:
For additional information or assistance about minikube, reach out on the
|
@tstromberg . Is this pull request ready? If so, please squash your commits. Thanks! |
@tstromberg thanks for the PR! Do you have interest in resolving the conflicts and addressing the feedback? Given the time this PR has been open, the next PR wrangler may close this if there's no action. Thanks! |
@tstromberg: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Okay to close? @tstromberg |
@tstromberg if you want to update that page and open a new PR from your branch, go ahead (and please mention that the new PR is a continuation of #20717). You'll need to rebase your branch against master BTW. |
/close |
@sftim: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Update the minikube installation document to be in-line with the guidance we provide users at https://minikube.sigs.k8s.io/docs/start/
Preview URL: https://deploy-preview-20717--kubernetes-io-master-staging.netlify.app/docs/tasks/tools/install-minikube/
Specific changes:
Related issues:
/cc @zacharysarah @afbjorklund @prasadkatti @medyagh @priyawadhwa @sharifelgamal