Update docs/tasks/tools/install-minikube #23354

inductor · 2020-08-23T09:42:00Z

This is a Feature Request

Install Minikube doesn't follow the latest information where you no longer need a hypervisor in order to use the minikube cluster as the default driver is Docker now.

Ref. https://minikube.sigs.k8s.io/docs/drivers/

What would you like to be added

Update the doc

Why is this needed

It doesn't follow the latest information

Comments
/lang en
/good-first-issue

rbrishabh · 2020-08-23T11:28:39Z

Hey! I would like to work on this! Can you provide more info on what the new docs should say?
Thanks

inductor · 2020-08-23T11:50:53Z

Install a Hypervisor should be optional and the doc does not mention about Docker driver which is recommended in the official doc(read the ref)

rbrishabh · 2020-08-23T18:24:45Z

Okay, got it! Will make a PR soon.
Thanks!

sftim · 2020-08-23T18:32:10Z

/priority important-longterm
/kind bug
/language en

However, as the work is not clearly defined:
/remove-good-first-issue

sftim · 2020-08-23T18:34:36Z

I'd replace Install a hypervisor with another section Ensure you have what you need (or similar title).

celestehorgan · 2020-09-28T16:24:33Z

@rbrishabh doesn't appear to have updated this, and I need a good first issue to train up a new member of CNCF docs/dev advocacy staff, so I'm going to take this one 👍

cc: @hackabletype. Please comment on this issue with /assign to assign yourself.

(nb. Nate: hold. Do not action on this until we meet later this afternoon.)

k8s-ci-robot · 2020-09-28T16:24:35Z

@celestehorgan: GitHub didn't allow me to assign the following users: hackabletype.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

@rbrishabh doesn't appear to have updated this, and I need a good first issue to train up a new member of CNCF docs/dev advocacy staff, so I'm going to take this one 👍

/assign @hackabletype

(nb. Nate: hold. Do not action on this until we meet later this afternoon.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rbrishabh · 2020-09-28T16:31:16Z

Sorry! I got busy with other work! Please feel free to work on this, thanks!

nate-double-u · 2020-09-28T18:25:59Z

/assign

nate-double-u · 2020-09-28T21:30:39Z

Hi @inductor, based on another conversation, we may solve this issue by removing the minikube installation as dual sourced content, and replacing this page with a link to the minikube installer documentation.

@tstromberg we are thinking of removing this page and replacing it with a link to minikube installer documentation. Do you think this is appropriate y/n?

celestehorgan · 2020-09-28T21:38:20Z

@hackabletype

As a part of this change, it might be worth making the links to Kind and Minikube a bit more visual/see-able. For example, using a button like here: https://kubernetes.io/docs/home/#understand-the-basics

nate-double-u · 2020-10-07T00:54:25Z

Karen B shared this PR in the Sig-Docs weekly meeting: #20717. It looks like it does the page trimming that we're looking at doing in this issue.

@celestehorgan

… installation as dual sourced content, and replacing this page with a link to the minikube installer documentation. Removing content/en/docs/tasks/tools/install-minikube.md file. Updating content/en/docs/tasks/tools/_index.mb file to link out directly to the minikube.sigs.k8s.io getting started page using @celestehorgan's button suggestion. Updating other sections to link out using buttons to keep consistency across the page. Signed-off-by: Nate W <[email protected]>

@celestehorgan

As per conversations in issue kubernetes#23354, * Removing content/en/docs/tasks/tools/install-minikube.md page * Updating content/en/docs/tasks/tools/_index.md with @celestehorgan's suggestion to add buttons to make these links more visual/see-able Signed-off-by: Nate W <[email protected]>

As per conversations in issue kubernetes#23354, * Removing content/en/docs/tasks/tools/install-minikube.md page * Updating content/en/docs/tasks/tools/_index.md with the suggestion to add buttons to make these links more visual/see-able Signed-off-by: Nate W <[email protected]>

sftim · 2020-10-08T16:22:15Z

Should we also amend / remove https://k8s.io/docs/setup/learning-environment/minikube/ and https://k8s.io/docs/setup/learning-environment/kind/ ?

As per conversations in issue kubernetes#23354, * Removing content/en/docs/tasks/tools/install-minikube.md page * Updating content/en/docs/tasks/tools/_index.md with the suggestion to add buttons to make these links more visual/see-able * Adding a 307 temporary redirect for /docs/tasks/tools/install-minikube/ Signed-off-by: Nate W <[email protected]>

As per conversations in issue kubernetes#23354, * Removing content/en/docs/tasks/tools/install-minikube.md page * Updating content/en/docs/tasks/tools/_index.md with the suggestion to add buttons to make these links more visual/see-able, including aria-labels * Adding a 307 temporary redirect for /docs/tasks/tools/install-minikube/ Signed-off-by: Nate W <[email protected]>

As per conversations in issue kubernetes#23354, * Removing content/en/docs/tasks/tools/install-minikube.md page * Adding a 302 temporary redirect for /docs/tasks/tools/install-minikube/ Additionally: * Updating content/en/docs/tasks/tools/_index.md with the suggestion to add buttons to make these links more visual/see-able, including aria-labels * Updating minikube capitalization throughout page * Updating text throughout page for line length Signed-off-by: Nate W <[email protected]>

As per conversations in issue kubernetes#23354, * Removing content/en/docs/tasks/tools/install-minikube.md page * Adding a 302 temporary redirect for /docs/tasks/tools/install-minikube/ * Updating content/en/docs/tasks/tools/_index.md with the suggestion to add buttons to make these links more visual/see-able, including aria-labels Additionally: * Updating minikube capitalization throughout page * Updating text throughout page for line length * Correcting back ticks use throughout page Signed-off-by: Nate W <[email protected]>

nate-double-u · 2020-10-10T18:17:57Z

Should we also amend / remove https://k8s.io/docs/setup/learning-environment/minikube/ and https://k8s.io/docs/setup/learning-environment/kind/ ?

Revising my previous comment, now removed:

I think that the https://k8s.io/docs/setup/learning-environment/kind/ page isn't doing very much, and can probably be combined with its parent page. Or, we can expand it to match the content style of the minikube page.
The https://k8s.io/docs/setup/learning-environment/minikube/ page looks to be in good shape (I went through it recently as a part of an on-boarding process). I'm not seeing much duplication from the main minikube site (please correct me if I'm wrong on that). What amendments would you suggest @sftim?

sftim · 2020-11-29T22:02:07Z

The page at https://kubernetes.io/docs/tasks/tools/install-minikube/ is gone.
/close

k8s-ci-robot · 2020-11-29T22:02:19Z

@sftim: Closing this issue.

In response to this:

The page at https://kubernetes.io/docs/tasks/tools/install-minikube/ is gone.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 23, 2020

k8s-ci-robot assigned nate-double-u Sep 28, 2020

nate-double-u mentioned this issue Oct 7, 2020

Remove content/en/docs/tasks/tools/install-minikube.md #24416

Merged

sftim mentioned this issue Oct 16, 2020

Redirect "Learning environment" to Install Tools task #24533

Merged

k8s-ci-robot closed this as completed Nov 29, 2020

nate-double-u mentioned this issue Dec 22, 2020

REQUEST: New membership for @nate-double-u kubernetes/org#2396

Closed

6 tasks

ariscahyadi mentioned this issue Mar 14, 2021

Tracking Indonesian Translation Progress (M6) #26955

Closed

40 tasks

divya-mohan0209 added this to SIG Docs Longterm issues Aug 17, 2023

divya-mohan0209 moved this to Todo in SIG Docs Longterm issues Aug 17, 2023

divya-mohan0209 removed this from SIG Docs Longterm issues Aug 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update docs/tasks/tools/install-minikube #23354

Update docs/tasks/tools/install-minikube #23354

inductor commented Aug 23, 2020 •

edited

Loading

rbrishabh commented Aug 23, 2020

inductor commented Aug 23, 2020

rbrishabh commented Aug 23, 2020

sftim commented Aug 23, 2020

sftim commented Aug 23, 2020

celestehorgan commented Sep 28, 2020 •

edited

Loading

k8s-ci-robot commented Sep 28, 2020

rbrishabh commented Sep 28, 2020

nate-double-u commented Sep 28, 2020

nate-double-u commented Sep 28, 2020

celestehorgan commented Sep 28, 2020

nate-double-u commented Oct 7, 2020

sftim commented Oct 8, 2020 •

edited

Loading

nate-double-u commented Oct 10, 2020

sftim commented Nov 29, 2020

k8s-ci-robot commented Nov 29, 2020

Update docs/tasks/tools/install-minikube #23354

Update docs/tasks/tools/install-minikube #23354

Comments

inductor commented Aug 23, 2020 • edited Loading

rbrishabh commented Aug 23, 2020

inductor commented Aug 23, 2020

rbrishabh commented Aug 23, 2020

sftim commented Aug 23, 2020

sftim commented Aug 23, 2020

celestehorgan commented Sep 28, 2020 • edited Loading

k8s-ci-robot commented Sep 28, 2020

rbrishabh commented Sep 28, 2020

nate-double-u commented Sep 28, 2020

nate-double-u commented Sep 28, 2020

celestehorgan commented Sep 28, 2020

nate-double-u commented Oct 7, 2020

sftim commented Oct 8, 2020 • edited Loading

nate-double-u commented Oct 10, 2020

sftim commented Nov 29, 2020

k8s-ci-robot commented Nov 29, 2020

inductor commented Aug 23, 2020 •

edited

Loading

celestehorgan commented Sep 28, 2020 •

edited

Loading

sftim commented Oct 8, 2020 •

edited

Loading