Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating docs for EndpointSlice changes in 1.18 #19316

Merged
merged 1 commit into from
Mar 14, 2020
Merged

Updating docs for EndpointSlice changes in 1.18 #19316

merged 1 commit into from
Mar 14, 2020

Conversation

robscott
Copy link
Member

This includes updates to the EndpointSlice documentation to cover the changes in 1.18. This is primarily that the EndpointSlice feature gate has been split into two. The EndpointSlice gate affects everything but kube-proxy, and a new EndpointSliceProxying gate affects kube-proxy. In addition to that, the EndpointSlice feature gate is now enabled by default (not the new EndpointSliceProxying gate).

Enhancement Issue: kubernetes/enhancements#752
PR this is documenting: kubernetes/kubernetes#86137

/sig network
/cc @sftim

@k8s-ci-robot k8s-ci-robot requested a review from sftim February 25, 2020 22:24
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 25, 2020
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Feb 25, 2020 •
edited
Loading

Deploy preview for kubernetes-io-vnext-staging processing.

Building with commit f8c9078

https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/5e67e6140a6663000b00149c

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Feb 25, 2020
@robscott robscott mentioned this pull request Feb 25, 2020
Closed
@irvifa
Copy link
Member

irvifa commented Mar 6, 2020

@sftim can you lend us a hand in reviewing this docs?
also wondering who can help us to tech review this part

@irvifa
Copy link
Member

irvifa commented Mar 7, 2020

/cc @kubernetes/sig-network-misc

sftim
sftim reviewed Mar 7, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look uncontroversial and kind of robotic: it's about more of the feature graduating to beta.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2020
@VineethReddy02
Copy link
Contributor

👋 Please rebase this PR on dev-1.18 in order to avoid merge conflicts.

Feel free to /hold cancel after you've rebased.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2020
@robscott robscott force-pushed the endpointslice-1.18 branch from f68bc69 to 234fec3 Compare March 10, 2020 18:06
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@robscott
Copy link
Member Author

@VineethReddy02 Just rebased on dev-1.18, let me know if I need to make any other changes to get this in.

@robscott
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2020
sftim
sftim reviewed Mar 10, 2020
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@robscott I've also suggested some tweaks; what do you think?

content/en/docs/tasks/administer-cluster/enabling-endpointslices.md Outdated Show resolved Hide resolved
content/en/docs/tasks/administer-cluster/enabling-endpointslices.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@robscott robscott force-pushed the endpointslice-1.18 branch from 234fec3 to f8c9078 Compare March 10, 2020 19:10
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@sftim
Copy link
Contributor

sftim commented Mar 10, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2020
@sftim
Copy link
Contributor

sftim commented Mar 12, 2020

/milestone 1.18

@k8s-ci-robot
Copy link
Contributor

@sftim: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Mar 12, 2020

@kubernetes/website-milestone-maintainers this is for v1.18

@sftim
Copy link
Contributor

sftim commented Mar 12, 2020

Oops, that's a bigger Cc: list than I realized

@VineethReddy02
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VineethReddy02

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 24005e8 into kubernetes:dev-1.18 Mar 14, 2020
@mateiidavid mateiidavid mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

Assignees

@sftim sftim

@VineethReddy02 VineethReddy02

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@robscott @k8sio-netlify-preview-bot @irvifa @VineethReddy02 @sftim @k8s-ci-robot