Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EndpointSlice API #752

Closed
freehan opened this issue Jan 29, 2019 · 130 comments · Fixed by #2882
Closed

EndpointSlice API #752

freehan opened this issue Jan 29, 2019 · 130 comments · Fixed by #2882
Assignees
@robscott @freehan @swetharepakula
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network Categorizes an issue or PR as relevant to SIG Network. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone
v1.25

Comments

@freehan
Copy link
Contributor

freehan commented Jan 29, 2019 •
edited by kikisdeliveryservice
Loading

Enhancement Description

  • One-line enhancement description (can be used as a release note): New Endpoint API as eventual replacement of the current core/v1 Endpoints API.
  • Primary contact (assignee): @freehan
  • Responsible SIGs: sig-network, sig-scalability
  • Kubernetes Enhancement Proposal PR: KEP: EndpointSlice API  #1086
  • Kubernetes Enhancement Proposal:https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/0752-endpointslices
  • Link to e2e and/or unit tests: TBD
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @thockin @wojtek-t
  • Approver (likely from SIG/area to which enhancement belongs): @thockin @wojtek-t
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.15)
    • Beta release target (1.16)
    • Stable release target (1.17)
@freehan freehan added this to the v1.14 milestone Jan 29, 2019
@freehan freehan self-assigned this Jan 29, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 29, 2019
@freehan freehan added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Jan 29, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 29, 2019
@freehan freehan added the sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. label Jan 29, 2019
@liggitt liggitt added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jan 31, 2019
@liggitt
Copy link
Member

liggitt commented Jan 31, 2019

was this intended to be targeted at 1.14 or 1.15?

@liggitt
Copy link
Member

liggitt commented Jan 31, 2019

moving to 1.15, since there's no design in progress yet
/milestone v1.15

@k8s-ci-robot
Copy link
Contributor

@liggitt: The provided milestone is not valid for this repository. Milestones in this repository: [keps-beta, keps-ga, v1.13, v1.14]

Use /milestone clear to clear the milestone.

In response to this:

moving to 1.15, since there's no design in progress yet
/milestone v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@liggitt liggitt modified the milestones: v1.14, v1.15 Jan 31, 2019
@wojtek-t
Copy link
Member

We would like to have the KEP approved in 1.14 timeframe, so that we would be able to reach alpha in 1.15.

@liggitt
Copy link
Member

liggitt commented Jan 31, 2019

sounds good; that means the actual changes are targeting 1.15, so I think the 1.15 milestone is accurate

@wojtek-t
Copy link
Member

Agree.

@kacole2
Copy link

kacole2 commented Apr 11, 2019

Hello @wojtek-t @freehan, I'm the Enhancement Lead for 1.15. Is this feature going to be targeting alpha in 1.15? I do not see a KEP which is required. Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 14, 2019
@wojtek-t
Copy link
Member

Yes - we're targetting 1.15 for Alpha release. Will keep it issue updated.

@mrbobbytables
Copy link
Member

@freehan, @wojtek-t Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@freehan
Copy link
Contributor Author

freehan commented Apr 30, 2019 •
edited
Loading

The proposal is already out. It has been shared with the community and still in discussion. KEP is not merged yet.

https://docs.google.com/document/d/1sLJfolOeEVzK5oOviRmtHOHmke8qtteljQPaDUEukxY/edit#heading=h.3v0n1vmx9wtr

@mrbobbytables
Copy link
Member

@freehan @wojtek-t The Enhancement Freeze for Kubernetes 1.15 has passed and this did not meet the deadline. This is now being removed from the 1.15 milestone and the tracking sheet. If there is a need for this to be in 1.15, please file an Enhancement Exception. Thank you.

@mrbobbytables mrbobbytables removed this from the v1.15 milestone May 1, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 1, 2019
@bgrant0607 bgrant0607 mentioned this issue May 8, 2019
Closed
@kacole2
Copy link

kacole2 commented Jul 9, 2019

Hi @freehan @wojtek-t , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@freehan
Copy link
Contributor Author

freehan commented Jul 9, 2019

@kacole2 I do not have permission to add it into spreadsheet. Would you mind adding me to it?

KEP in flight: #1086

@kacole2 kacole2 added this to the v1.16 milestone Jul 9, 2019
@swetharepakula
Copy link
Member

/assign @swetharepakula

@ritpanjw
Copy link

Hello @swetharepakula 👋 , 1.22 Docs Shadow here.

This enhancement is marked as Needs Docs for 1.22 release.
Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.
Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you!

@reylejano
Copy link
Member

Hi @swetharepakula ,
Are there any code changes planned for the 1.22 release?

@swetharepakula
Copy link
Member

Hi @reylejano 👋 ,

There are some code changes that are planned for this release (most likely will span over a couple PRs). I have not yet submitted them yet, but will make sure to link them to this issue when I submit.

@swetharepakula swetharepakula mentioned this issue Jun 29, 2021
Merged
@reylejano
Copy link
Member

Hi @swetharepakula ,

I see that kubernetes/kubernetes#103306 was linked and is merged.
Are there any additional k/k PRs required for 1.22 before code freeze on July 8, 2021?

Also a reminder that the Docs Placeholder PR deadline is on July 9, 2021.
Here are instructions on opening a PR against the dev-1.22 branch in the k/website repo

@swetharepakula swetharepakula mentioned this issue Jul 2, 2021
Merged
@swetharepakula
Copy link
Member

Hi @reylejano,

I am hoping to get 2 more PRs in. They are both WIPs at this moment. However, kubernetes/kubernetes#103306 was the most crucial one.

I have opened up the draft docs PR: kubernetes/website#28745

@swetharepakula swetharepakula mentioned this issue Jul 2, 2021
Merged
@reylejano
Copy link
Member

reylejano commented Jul 6, 2021 •
edited
Loading

Hi @swetharepakula ,

Just a reminder that the 1.22 code freeze starts in a few days on Thursday, July 8 at 18:00 PDT. The following PR and any other PR required for this enhancement for 1.22 has to merge by then:

This enhancement is currently at-risk of falling out of 1.22 with kubernetes/kubernetes#103451 open

@swetharepakula swetharepakula mentioned this issue Jul 6, 2021
Merged
@swetharepakula
Copy link
Member

kubernetes/kubernetes#103451 & kubernetes/kubernetes#103520 need to be merged for close out this kep.

The higher priority is kubernetes/kubernetes#103451.

@swetharepakula
Copy link
Member

Both kubernetes/kubernetes#103451 & kubernetes/kubernetes#103520 have been approved. We are just waiting on merging for both

@swetharepakula
Copy link
Member

All PRs for this KEP have been merged.

@reylejano
Copy link
Member

Hi @swetharepakula ,

With the following PRs merged, this enhancement is set for the 1.22 code freeze 🎉

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 12, 2021
@salaxander
Copy link
Contributor

Hi @swetharepakula - Could you open a PR on the KEP to change the status to implemented? At that point we can close out the issue :)

Thanks!

@salaxander salaxander removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Aug 19, 2021
@swetharepakula swetharepakula mentioned this issue Aug 19, 2021
Merged
@thockin thockin modified the milestones: v1.22, v1.25 Feb 16, 2022
@thockin
Copy link
Member

thockin commented Feb 16, 2022

Reminder: Remove gate in 1.25, milestone updated

@thockin thockin moved this to Done in SIG Network KEPs Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robscott robscott

@freehan freehan

@swetharepakula swetharepakula

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network Categorizes an issue or PR as relevant to SIG Network. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
SIG Network KEPs
Status: Done
Milestone
v1.25
Development

Successfully merging a pull request may close this issue.

KEP-752: Updating status to implemented swetharepakula/enhancements