-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Polish localization #18254
Init Polish localization #18254
Conversation
Welcome @mfilocha! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A related PR to open Polish Slack channel: kubernetes/community#4348 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mfilocha
It's great to see you've made a start on this.
For a localization typically you will need at least 2 contributors and some initial work. https://github.com/kubernetes/website/pull/12548/files shows an example of how the French localization started out, including a fr.toml
for strings localization.
(I don't speak Polish, so this is mainly to thank you for what you've done so far and to drop a hint about the work you need to do to move this from a work-in-progress).
Another thing: I recommend creating a new branch for the initial Polish localization; see https://kubernetes.io/docs/contribute/localization/#branching-strategy |
@nvtkaszpir Would you consider be included as a reviewer in this localization? |
|
||
## Twój wkład w dokumentację | ||
|
||
Możesz kliknąć w przycisk **Fork** w prawym górnym rogu ekranu, aby stworzyć kopię tego repozytorium na swoim koncie GitHub. Taki rodzaj kopii (odgałęzienia) nazywa się *fork*. Zmieniaj w nim, co chcesz, a kiedy będziesz już gotowy/a przesłać te zmiany do nas, przejdź do swojej kopii i stwórz nowy *pull request*, abyśmy zostali o tym poinformowani. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's worth to create additional page for abbreviations/disambiguation for such phrases as fork
, pull request
and so on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can start with this: https://github.com/nurkiewicz/polski-w-it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no translation of fork there :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither pull request...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to, add some of those terms to https://kubernetes.io/docs/reference/glossary/?community=true
but then every localization has to translate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Fork is explained later in the first paragraph. As for pull request, I am not familiar with any good term for that in Polish.
Perhaps we could contribute some vocabulary back to https://github.com/nurkiewicz/polski-w-it ?
I think translations of newer or less commonly used terms into Polish are a wider problem. From what I've seen closer to me, people just use the English terms where there's no good translation available. And I've seen lack of good translated terms in a lot of places.
I suspect we'll run into quite a few words I always had a hard time translating - such as "packaging".
I'm not sure what's the best option here, but I think this is something we may want to address early on and define how to handle it.
|
||
## Twój wkład w dokumentację | ||
|
||
Możesz kliknąć w przycisk **Fork** w prawym górnym rogu ekranu, aby stworzyć kopię tego repozytorium na swoim koncie GitHub. Taki rodzaj kopii (odgałęzienia) nazywa się *fork*. Zmieniaj w nim, co chcesz, a kiedy będziesz już gotowy/a przesłać te zmiany do nas, przejdź do swojej kopii i stwórz nowy *pull request*, abyśmy zostali o tym poinformowani. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can start with this: https://github.com/nurkiewicz/polski-w-it
Co-Authored-By: janisz <[email protected]>
Co-Authored-By: janisz <[email protected]>
/language pl |
@sftim: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
README-pl.md
Outdated
|[Japanese README](README-ja.md)|[Polish README](README-pl.md)| | ||
||| | ||
|
||
## Jak uruchomić serwis internetowy lokalnie przy pomocy Dockera |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jak wygenerować dokumentację lokalnie
feels a bit less awkward, don't you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, but it depends on how much we want to follow the original text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about: "Jak uruchomić lokalnie stronę z dokumentacją przy pomocy Dockera?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on English translation, the text is "Running the website locally using Docker". Earlier there's "(...)the Kubernetes website and documentation", which was translated as "strony internetowej Kubernetes wraz z dokumentacją".
Why not just "Jak uruchomić stronę internetową Kubernetes lokalnie przy pomocy Dockera"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nvtkaszpir was not happy about the original translation.
Hi @sftim
I'm aware of this requirements. I'm currently in search of authorized reviewers. |
Co-Authored-By: janisz <[email protected]>
@mfilocha Every translation needs to have a minimum of 2 owners, otherwise when you submit a pull request nobody can approve except the sig-docs-maintainers, which doesn't make sense because they can't review. In this case please add @nvtkaszpir as well to the owners section. |
@remyleone / @mfilocha why is the pull request opened against the 1.17 branch instead of the 'master' branch? This is the initial translation so we probably want to have this against our latest/master branch as well. |
@nvtkaszpir you need to request org membership as well. For that you need to have 2 sponsors. I can sponsor you and probably @remyleone wants to sponsor you as well, right? |
I will sponsor you @nvtkaszpir :) |
@sftim Waiting for the language label: kubernetes/test-infra#15684 |
/assign @jimangel |
This PR needs to be opened against master, not /hold |
@mfilocha Are there remaining open issues about this Pull Request? Otherwise, we can close this one and open a new one that targets master. |
@remyleone @jimangel I'll keep this PR open for a while to resolve remaining topics and then I'll open a new PR against the master branch, as advised. |
Co-Authored-By: Karol Pucyński <[email protected]>
The following users are mentioned in OWNERS file(s) but are not members of the kubernetes org. Once all users have been added as members of the org, you can trigger verification by writing
|
I created another PR: #18419 as advised by reviewers. This one is going to be closed today without merging. |
/close |
@sftim: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
An initial config for Polish localization.