Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init Polish localization #18254

Closed
wants to merge 16 commits into from
Closed

Conversation

mfilocha
Copy link
Contributor

An initial config for Polish localization.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 23, 2019
@k8s-ci-robot
Copy link
Contributor

Welcome @mfilocha!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 23, 2019
@k8s-ci-robot k8s-ci-robot requested review from sftim and tengqm December 23, 2019 15:12
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign daminisatya
You can assign the PR to them by writing /assign @daminisatya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Dec 23, 2019
@mfilocha
Copy link
Contributor Author

A related PR to open Polish Slack channel: kubernetes/community#4348

Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mfilocha

It's great to see you've made a start on this.
For a localization typically you will need at least 2 contributors and some initial work. https://github.com/kubernetes/website/pull/12548/files shows an example of how the French localization started out, including a fr.toml for strings localization.

(I don't speak Polish, so this is mainly to thank you for what you've done so far and to drop a hint about the work you need to do to move this from a work-in-progress).

README-pl.md Outdated Show resolved Hide resolved
README-pl.md Outdated Show resolved Hide resolved
config.toml Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Dec 23, 2019

Another thing: I recommend creating a new branch for the initial Polish localization; see https://kubernetes.io/docs/contribute/localization/#branching-strategy

@remyleone
Copy link
Contributor

remyleone commented Dec 23, 2019

@nvtkaszpir Would you consider be included as a reviewer in this localization?

@remyleone remyleone changed the title Minimal config for Polish content Init Polish localization Dec 23, 2019
README-pl.md Outdated Show resolved Hide resolved

## Twój wkład w dokumentację

Możesz kliknąć w przycisk **Fork** w prawym górnym rogu ekranu, aby stworzyć kopię tego repozytorium na swoim koncie GitHub. Taki rodzaj kopii (odgałęzienia) nazywa się *fork*. Zmieniaj w nim, co chcesz, a kiedy będziesz już gotowy/a przesłać te zmiany do nas, przejdź do swojej kopii i stwórz nowy *pull request*, abyśmy zostali o tym poinformowani.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth to create additional page for abbreviations/disambiguation for such phrases as fork, pull request and so on?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no translation of fork there :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither pull request...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to, add some of those terms to https://kubernetes.io/docs/reference/glossary/?community=true

but then every localization has to translate them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Fork is explained later in the first paragraph. As for pull request, I am not familiar with any good term for that in Polish.

Perhaps we could contribute some vocabulary back to https://github.com/nurkiewicz/polski-w-it ?

I think translations of newer or less commonly used terms into Polish are a wider problem. From what I've seen closer to me, people just use the English terms where there's no good translation available. And I've seen lack of good translated terms in a lot of places.

I suspect we'll run into quite a few words I always had a hard time translating - such as "packaging".

I'm not sure what's the best option here, but I think this is something we may want to address early on and define how to handle it.

README-pl.md Outdated Show resolved Hide resolved
README-pl.md Outdated Show resolved Hide resolved
README-pl.md Outdated Show resolved Hide resolved

## Twój wkład w dokumentację

Możesz kliknąć w przycisk **Fork** w prawym górnym rogu ekranu, aby stworzyć kopię tego repozytorium na swoim koncie GitHub. Taki rodzaj kopii (odgałęzienia) nazywa się *fork*. Zmieniaj w nim, co chcesz, a kiedy będziesz już gotowy/a przesłać te zmiany do nas, przejdź do swojej kopii i stwórz nowy *pull request*, abyśmy zostali o tym poinformowani.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mfilocha and others added 2 commits December 23, 2019 17:28
@sftim
Copy link
Contributor

sftim commented Dec 23, 2019

/language pl
?

@k8s-ci-robot
Copy link
Contributor

@sftim: The label(s) language/pl cannot be applied, because the repository doesn't have them

In response to this:

/language pl
?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

README-pl.md Outdated
|[Japanese README](README-ja.md)|[Polish README](README-pl.md)|
|||

## Jak uruchomić serwis internetowy lokalnie przy pomocy Dockera
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jak wygenerować dokumentację lokalnie feels a bit less awkward, don't you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, but it depends on how much we want to follow the original text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about: "Jak uruchomić lokalnie stronę z dokumentacją przy pomocy Dockera?"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on English translation, the text is "Running the website locally using Docker". Earlier there's "(...)the Kubernetes website and documentation", which was translated as "strony internetowej Kubernetes wraz z dokumentacją".

Why not just "Jak uruchomić stronę internetową Kubernetes lokalnie przy pomocy Dockera"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nvtkaszpir was not happy about the original translation.

README-pl.md Outdated Show resolved Hide resolved
@mfilocha
Copy link
Contributor Author

Hi @sftim

For a localization typically you will need at least 2 contributors and some initial work. https://github.com/kubernetes/website/pull/12548/files shows an example of how the French localization started out, including a fr.toml for strings localization.

I'm aware of this requirements. I'm currently in search of authorized reviewers.
And I created a minimum set of transtlation for version 1.16, which I'm going to update to 1.17 soon and start creating PRs:
release-1.16...mfilocha:dev-1.16-pl.1

README-pl.md Outdated Show resolved Hide resolved
@rlenferink
Copy link
Member

@nvtkaszpir Would you consider be included as a reviewer in this localization?

yes, please.

@mfilocha Every translation needs to have a minimum of 2 owners, otherwise when you submit a pull request nobody can approve except the sig-docs-maintainers, which doesn't make sense because they can't review. In this case please add @nvtkaszpir as well to the owners section.

@rlenferink
Copy link
Member

@remyleone / @mfilocha why is the pull request opened against the 1.17 branch instead of the 'master' branch? This is the initial translation so we probably want to have this against our latest/master branch as well.

@rlenferink
Copy link
Member

@nvtkaszpir you need to request org membership as well. For that you need to have 2 sponsors. I can sponsor you and probably @remyleone wants to sponsor you as well, right?

@remyleone
Copy link
Contributor

I will sponsor you @nvtkaszpir :)

@mfilocha
Copy link
Contributor Author

@sftim Waiting for the language label: kubernetes/test-infra#15684

@idealhack
Copy link
Member

/assign @jimangel

@jimangel
Copy link
Member

This PR needs to be opened against master, not dev-1.17. Also, please squash the commits if possible. Let me know if you need assistance with anything! Thanks!

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2019
@remyleone
Copy link
Contributor

@mfilocha Are there remaining open issues about this Pull Request? Otherwise, we can close this one and open a new one that targets master.

@mfilocha
Copy link
Contributor Author

@remyleone @jimangel I'll keep this PR open for a while to resolve remaining topics and then I'll open a new PR against the master branch, as advised.

config.toml Outdated Show resolved Hide resolved
Co-Authored-By: Karol Pucyński <[email protected]>
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the kubernetes org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • nvtkaszpir
    • OWNERS_ALIASES

@mfilocha
Copy link
Contributor Author

mfilocha commented Jan 2, 2020

I created another PR: #18419 as advised by reviewers. This one is going to be closed today without merging.

@sftim
Copy link
Contributor

sftim commented Jan 2, 2020

/close
as per #18254 (comment)

@k8s-ci-robot
Copy link
Contributor

@sftim: Closed this PR.

In response to this:

/close
as per #18254 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfilocha mfilocha deleted the dev-1.17-pl.1 branch January 15, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.