Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable docker in docker for ingress-gce #6107

Merged
merged 1 commit into from
Jan 3, 2018
Merged

enable docker in docker for ingress-gce #6107

merged 1 commit into from
Jan 3, 2018

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Dec 28, 2017 •
edited
Loading

This should fix kubernetes/ingress-gce#93

I think we can safely flip this on without worrying about the cache filling up for now but I'd reallly prefer to get #6106 in.

/area jobs

@k8s-ci-robot k8s-ci-robot added area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2017
@BenTheElder
Copy link
Member Author

FYI @rramkumar1

@BenTheElder BenTheElder mentioned this pull request Jan 2, 2018
Merged
@BenTheElder
Copy link
Member Author

This should be merged following #6125 if someone wants to LGTM and hold cancel then
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2018
@fejta
Copy link
Contributor

fejta commented Jan 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, fejta

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2018
@k8s-ci-robot k8s-ci-robot merged commit a6260c7 into kubernetes:master Jan 3, 2018
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: I updated Prow config for you!

In response to this:

This should fix kubernetes/ingress-gce#93

I think we can safely flip this on without worrying about the cache filling up for now but I'd reallly prefer to get #6106 in.

/area jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder BenTheElder deleted the ingress-gce-dind branch January 3, 2018 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@fejta fejta

@krzyzacy krzyzacy

@cjwagner cjwagner

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ingress E2E setup is breaking
6 participants
@BenTheElder @fejta @k8s-ci-robot @krzyzacy @cjwagner @ixdy