Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cluster-autoscaler Azure e2e jobs for older release branches #33375

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Aug 27, 2024

Follow-up from #33361 to add Azure e2e tests for the 1.27, 1.28, and 1.29 branches of cluster-autoscaler.

For the master branch, this requires some changes made by kubernetes/autoscaler#7214:

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 27, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2024
@k8s-ci-robot
Copy link
Contributor

@rakechill: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Sep 5, 2024

For the master branch, this requires some changes made by kubernetes/autoscaler#7214:

/hold

This PR and that one are actually co-dependent, so it doesn't really matter what order these get merged.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2024
Copy link
Member

@Bryce-Soghigian Bryce-Soghigian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bryce-Soghigian, nojnhuh, rakechill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit acd7f9c into kubernetes:master Sep 5, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@nojnhuh: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-autoscaler-azure-presubmits.yaml using file config/jobs/kubernetes/sig-autoscaling/azure/cluster-autoscaler-azure-presubmits.yaml

In response to this:

Follow-up from #33361 to add Azure e2e tests for the 1.27, 1.28, and 1.29 branches of cluster-autoscaler.

For the master branch, this requires some changes made by kubernetes/autoscaler#7214:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh nojnhuh deleted the cas-azure-e2e branch September 27, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants