align Azure e2e tests with backports #7214
Conversation
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
area/cluster-autoscaler
area/provider/azure
| @@ -1,3 +1,5 @@ | |||
| //go:build e2e | |||
There was a problem hiding this comment.
This build tag ensures that the go test invocation on release branches that use GO111MODULE=off doesn't catch Azure e2e packages since they will not contain unit tests.
| @@ -31,6 +30,7 @@ spec: | |||
| dnsPrefix: ${CLUSTER_NAME} | |||
| identity: | |||
| type: SystemAssigned | |||
| kubernetesVersion: "${KUBERNETES_VERSION}" | |||
There was a problem hiding this comment.
Moving the Kubernetes version here allows us to use AKS MAJOR.MINOR versions where CAPI requires spec.version to be formatted as MAJOR.MINOR.PATCH. This allows us to automatically inherit new patch releases when they become available in AKS.
|
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bryce-Soghigian, nojnhuh, rakechill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick cluster-autoscaler-release-1.31 |
|
@nojnhuh: new pull request created: #7248 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR forward-ports(?) some small changes made on release branches to enable Azure e2e tests to the master branch.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: