-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move NPD presubmit jobs to k8s-infra-prow-build #32228
Move NPD presubmit jobs to k8s-infra-prow-build #32228
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wangzhen127 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @hakman |
/lgtm |
@wangzhen127: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@wangzhen127 @hakman are we sure there is no side effect https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/node-problem-detector/885/pull-npd-e2e-kubernetes-gce-gci/1767203130241454080 ? |
I still see
Reverting... |
@wangzhen127 I don't see the value of push an artifact during presubmit. The build should be enough ? |
While we are reverting the PR, I wonder why test-infra/config/jobs/kubernetes/node-problem-detector/node-problem-detector-ci.yaml Line 128 in b8c56e8
|
Issue ref: kubernetes/kubernetes#119211