Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining sig-node jobs to community clusters #31794

Closed
6 tasks done
rjsadow opened this issue Feb 1, 2024 · 19 comments
Closed
6 tasks done

Migrate remaining sig-node jobs to community clusters #31794

rjsadow opened this issue Feb 1, 2024 · 19 comments
Assignees
@BenTheElder
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@rjsadow
Copy link
Contributor

rjsadow commented Feb 1, 2024 •
edited by BenTheElder
Loading

The following jobs still run on the default google owned cluster and need to be migrated to a community cluster

node-problem-detector

containerd
@rjsadow rjsadow added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 1, 2024
@rjsadow
Copy link
Contributor Author

rjsadow commented Feb 1, 2024

/sig testing
/sig k8s-infra
/sig node

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 1, 2024
@rjsadow rjsadow mentioned this issue Feb 1, 2024
Closed
16 tasks
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 1, 2024
@rjsadow rjsadow changed the title Migrate remaining sig-node jobs to community clusters Migrate remaining sig-node jobs to community clusters Feb 1, 2024
@kannon92
Copy link
Contributor

kannon92 commented Feb 8, 2024

/help wanted
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@kannon92:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help wanted
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 8, 2024
@Bharadwajshivam28
Copy link
Contributor

Hey @rjsadow and @kannon92 I would like to work on this

@SD-13
Copy link
Contributor

SD-13 commented Feb 9, 2024

/assign
I can work on node-problem-detector
@Bharadwajshivam28 would you like to work on the containerd jobs?

@SD-13 SD-13 mentioned this issue Feb 9, 2024
Closed
@Bharadwajshivam28
Copy link
Contributor

/assign
I can work on node-problem-detector
@Bharadwajshivam28 would you like to work on the containerd jobs?

Ya works for me 😀

@Bharadwajshivam28
Copy link
Contributor

Bharadwajshivam28 commented Feb 9, 2024 •
edited
Loading

/assign

Working on containerd one

@alessandrocapanna alessandrocapanna mentioned this issue Mar 9, 2024
Closed
@SD-13
Copy link
Contributor

SD-13 commented Mar 11, 2024

@rjsadow FYI, node-problem-detector is migrated in this issue kubernetes/kubernetes#119211

@SD-13
Copy link
Contributor

SD-13 commented Mar 11, 2024

@Bharadwajshivam28 Are you working to migrate containerd jobs? If not, I can help with that.

@wangzhen127
Copy link
Member

wangzhen127 commented Mar 11, 2024 •
edited
Loading

I tried to migrate the NPD tests but still saw the 403 Forbidden error. I am not sure why the same tests can work in CI, but not in presubmits, or vice versa. My PRs have been reverted. @SD-13 if you have time to investigate more, it would be really appreciated.

@Bharadwajshivam28
Copy link
Contributor

@Bharadwajshivam28 Are you working to migrate containerd jobs? If not, I can help with that.

Hey you can go ahead with it

@SD-13
Copy link
Contributor

SD-13 commented Mar 12, 2024

/unassign @Bharadwajshivam28

@SD-13
Copy link
Contributor

SD-13 commented Mar 12, 2024 •
edited
Loading

@wangzhen127 I will dig into this issue!

ERROR: failed to solve: failed to push gcr.io/node-problem-detector-staging/ci/node-problem-detector:v0.8.16-14-gb48e438-20240311.1409: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://gcr.io/v2/token?scope=repository%3Anode-problem-detector-staging%2Fci%2Fnode-problem-detector%3Apull%2Cpush&service=gcr.io: 403 Forbidden

Will start from these logs.
Initially seems like, it didn't have necessary permissions or a good credential...

@SD-13 SD-13 mentioned this issue Mar 14, 2024
Closed
@endocrimes
Copy link
Member

#32261 (comment)

@ameukam do we have those documented anywhere? (if yes and they're solvable, point me in the right direction and i'll take a look in the next couple of weeks)

@wangzhen127
Copy link
Member

Is there any update? We need to finish the migration per kubernetes/node-problem-detector#920

@wangzhen127 wangzhen127 mentioned this issue Jul 1, 2024
Closed
@BenTheElder BenTheElder mentioned this issue Jul 8, 2024
Merged
@BenTheElder
Copy link
Member

kubernetes/node-problem-detector#925 stops pushing to a registry, only tarball in e2e, so we should be able to switch over to the community cluster for those jobs, the only question is which bucket, which is being discussed in https://kubernetes.slack.com/archives/CCK68P2Q2/p1720468658336129

@BenTheElder BenTheElder assigned BenTheElder and unassigned SD-13 Jul 8, 2024
@BenTheElder BenTheElder removed the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Jul 8, 2024
@BenTheElder
Copy link
Member

for NPD, we're tracking in kubernetes/node-problem-detector#920 and I'm making progress.

@BenTheElder
Copy link
Member

Almost there ... #33015

@BenTheElder
Copy link
Member

These are done now, more details in kubernetes/node-problem-detector#920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenTheElder BenTheElder

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@BenTheElder @endocrimes @wangzhen127 @kannon92 @rjsadow @k8s-ci-robot @SD-13 @Bharadwajshivam28