Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Images from GCR to AR #26916

Merged
merged 4 commits into from
Aug 16, 2022

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Jul 26, 2022

Fixes: kubernetes/k8s.io#3975

This change needs to be deployed first: kubernetes/k8s.io#3968

/cc @puerco @BenTheElder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jul 26, 2022
@upodroid
Copy link
Member Author

/cc @dims @ameukam

This can be merged now. It shouldn't affect the work in kubernetes/k8s.io#4065

@BenTheElder oci-proxy can start serving from AR once these jobs have ran for a few days and finish instead of getting killed by prow for taking too long.

I will revert this PR once images are being promoted directly to AR.

@k8s-ci-robot k8s-ci-robot requested review from ameukam and dims August 15, 2022 19:42
@dims
Copy link
Member

dims commented Aug 15, 2022

/approve
/lgtm

/hold please remove hold when ready

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2022
@puerco
Copy link
Member

puerco commented Aug 15, 2022

@upodroid I assume the plan is still to promote all new images asap while having these jobs running periodically to ensure consistency across all regions, right? (as opposed to simply having these for backfill purposes)

/lgtm

@upodroid
Copy link
Member Author

That is right. If the experimental promotion is fast enough:

  • we'll backfill AR
  • add AR manifests for all projects
  • revert this PR

@upodroid
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit bf093bc into kubernetes:master Aug 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key releng-gcr-to-ar-sync.yaml using file config/jobs/kubernetes/sig-k8s-infra/trusted/releng/releng-gcr-to-ar-sync.yaml

In response to this:

Fixes: kubernetes/k8s.io#3975

This change needs to be deployed first: kubernetes/k8s.io#3968

/cc @puerco @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk copy images from Google Container Registry to Artifact Registry
4 participants