Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Artifact Registry to Production Project #3968

Merged
merged 8 commits into from
Aug 9, 2022
Merged

Deploy Artifact Registry to Production Project #3968

merged 8 commits into from
Aug 9, 2022

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Jul 13, 2022 •
edited
Loading

Part of #1343
Part of #3961 Deferred as it is alot of work for minimal gain right now.

/cc @puerco

@k8s-ci-robot k8s-ci-robot requested a review from puerco July 13, 2022 11:07
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Jul 13, 2022
This was referenced Jul 13, 2022
Open
Closed
Closed
@upodroid upodroid mentioned this pull request Jul 26, 2022
Merged
@ameukam
Copy link
Member

ameukam commented Jul 26, 2022

@upodroid can we not touch the prod storage for the moment ? It was suggested by GCR team(I can't find the moment) we should use regional registries instead of multi-regional registries.

ameukam
ameukam reviewed Jul 26, 2022
View reviewed changes
infra/gcp/bash/lib_iam.sh Outdated Show resolved Hide resolved
@upodroid upodroid changed the title Deploy Artifact Registry to Staging and Prod Project Deploy Artifact Registry to Production Project Jul 26, 2022
@ameukam
Copy link
Member

ameukam commented Aug 2, 2022

/approve

Leaving the lgtm @kubernetes/release-engineering
(we'll now promote the images to more than 10 regions)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@ameukam ameukam mentioned this pull request Aug 3, 2022
Merged
ameukam
ameukam reviewed Aug 3, 2022
View reviewed changes
infra/gcp/bash/ensure-prod-storage.sh Outdated
PROD_REGIONS=(us eu asia)
GCR_PROD_REGIONS=(us eu asia)
# Regions for prod AR.
AR_PROD_REGIONS=(asia-east1 asia-south1 asia-northeast1 australia-southeast1 europe-north1 europe-southeast1 europe-west1 europe-west4 southamerica-west1 us-central1 us-east1 us-east4 us-west2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upodroid can we start with the locations of Cloud Run subject to Tier 1 pricing https://cloud.google.com/run/docs/locations ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added all Tier 1 regions.

Will bring this up at next week's sig-release meeting

@puerco
Copy link
Member

puerco commented Aug 9, 2022

Looks good to me, as discussed at the SIG Release meeting we will start processing time to the new registries using the new AR locations to ensure the promoter can handle the extra locations in time.

Thanks @upodroid !
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8b7a9b3 into kubernetes:main Aug 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 9, 2022
@upodroid upodroid mentioned this pull request Aug 10, 2022
Merged
@ameukam
Copy link
Member

ameukam commented Aug 10, 2022

Enabled the AR service. It may take a few minutes to enable it.

Failed to list repositories for the following locations: asia-east1. If you recently enabled the Artifact Registry API, the enablement status might not have propagated to these locations. Please try again later.

@ameukam
Copy link
Member

ameukam commented Aug 10, 2022

Issue with role naming.

  Ensuring the AR repositories: k8s-artifacts-prod 
    Ensuring prod AR registry for locations: asia-east1 asia-south1 asia-northeast1 asia-northeast2 australia-southeast1 europe-north1 europe-southeast1 europe-west1 europe-west2 europe-west4 europe-west8 europe-west9 southamerica-west1 us-central1 us-east1 us-east4 us-east5 us-south1 us-west1 us-west2 
      region: asia-east1 
      Ensuring an AR repo exists in location: asia-east1 for project: k8s-artifacts-prod 
      ERROR: Policy modification failed. For a binding with condition, run "gcloud alpha iam policies lint-condition" to identify issues in condition.
      ERROR: (gcloud.artifacts.repositories.add-iam-policy-binding) INVALID_ARGUMENT: The role name must be in the form "roles/{role}", "organizations/{organization_id}/roles/{role}", or "projects/{project_id}/roles/{role}".

I'll open a PR with the fix.

@ameukam
Copy link
Member

ameukam commented Aug 11, 2022

Deployment is done:

gcloud artifacts repositories list --project k8s-artifacts-prod
Listing items under project k8s-artifacts-prod, across all locations.

                                                                     ARTIFACT_REGISTRY
REPOSITORY  FORMAT  MODE                 DESCRIPTION  LOCATION              LABELS  ENCRYPTION          CREATE_TIME          UPDATE_TIME          SIZE (MB)
images      DOCKER  STANDARD_REPOSITORY               asia-east1                    Google-managed key  2022-08-10T18:51:54  2022-08-10T18:51:54  0
images      DOCKER  STANDARD_REPOSITORY               asia-northeast1               Google-managed key  2022-08-10T19:06:49  2022-08-10T19:06:49  0
images      DOCKER  STANDARD_REPOSITORY               asia-northeast2               Google-managed key  2022-08-10T19:07:22  2022-08-10T19:07:22  0
images      DOCKER  STANDARD_REPOSITORY               asia-south1                   Google-managed key  2022-08-10T19:06:10  2022-08-10T19:06:10  0
images      DOCKER  STANDARD_REPOSITORY               australia-southeast1          Google-managed key  2022-08-10T19:07:56  2022-08-10T19:07:56  0
images      DOCKER  STANDARD_REPOSITORY               europe-north1                 Google-managed key  2022-08-10T19:08:29  2022-08-10T19:08:29  0
images      DOCKER  STANDARD_REPOSITORY               europe-southwest1             Google-managed key  2022-08-10T19:16:48  2022-08-10T19:16:48  0
images      DOCKER  STANDARD_REPOSITORY               europe-west1                  Google-managed key  2022-08-10T19:17:10  2022-08-10T19:17:10  0
images      DOCKER  STANDARD_REPOSITORY               europe-west2                  Google-managed key  2022-08-10T19:17:30  2022-08-10T19:17:30  0
images      DOCKER  STANDARD_REPOSITORY               europe-west4                  Google-managed key  2022-08-10T19:17:49  2022-08-10T19:17:49  0
images      DOCKER  STANDARD_REPOSITORY               europe-west8                  Google-managed key  2022-08-10T19:18:10  2022-08-10T19:18:10  0
images      DOCKER  STANDARD_REPOSITORY               europe-west9                  Google-managed key  2022-08-10T19:18:31  2022-08-10T19:18:31  0
images      DOCKER  STANDARD_REPOSITORY               southamerica-west1            Google-managed key  2022-08-10T19:18:54  2022-08-10T19:18:54  0
images      DOCKER  STANDARD_REPOSITORY               us-central1                   Google-managed key  2022-08-10T19:19:20  2022-08-10T19:19:20  0
images      DOCKER  STANDARD_REPOSITORY               us-east1                      Google-managed key  2022-08-10T19:19:43  2022-08-10T19:19:43  0
images      DOCKER  STANDARD_REPOSITORY               us-east4                      Google-managed key  2022-08-10T19:20:05  2022-08-10T19:20:05  0
images      DOCKER  STANDARD_REPOSITORY               us-east5                      Google-managed key  2022-08-10T19:20:26  2022-08-10T19:20:26  0
images      DOCKER  STANDARD_REPOSITORY               us-south1                     Google-managed key  2022-08-10T19:20:47  2022-08-10T19:20:47  0
images      DOCKER  STANDARD_REPOSITORY               us-west1                      Google-managed key  2022-08-10T19:21:11  2022-08-10T19:21:11  0
images      DOCKER  STANDARD_REPOSITORY               us-west2                      Google-managed key  2022-08-10T19:21:37  2022-08-10T19:21:37  0

@ameukam ameukam mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam ameukam left review comments

@puerco puerco Awaiting requested review from puerco

Assignees

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bash Bash scripts, testing them, writing less of them, code in infra/gcp/ area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
registry.k8s.io (SIG K8S Infra)
Status: Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
4 participants
@upodroid @ameukam @k8s-ci-robot @puerco