Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding prow job to push windows-gmsa-webhook image #25306

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Adding prow job to push windows-gmsa-webhook image #25306

merged 1 commit into from
Feb 17, 2022

Conversation

marosset
Copy link
Contributor

Signed-off-by: Mark Rossetti [email protected]

/hold
wait for kubernetes-sigs/windows-gmsa#59 to merge

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2022
@marosset
Copy link
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Feb 16, 2022
@marosset
Copy link
Contributor Author

Part of kubernetes-sigs/windows-gmsa#52

@marosset marosset force-pushed the gmsa-post-submit-push-images branch from c3a7c31 to ebdf80d Compare February 16, 2022 21:39
@marosset marosset force-pushed the gmsa-post-submit-push-images branch from ebdf80d to c991c03 Compare February 16, 2022 22:10
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/testgrid sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 16, 2022
@marosset
Copy link
Contributor Author

/cc @jsturtevant

@marosset
Copy link
Contributor Author

/hold cancel

/assign @dims @spiffxp

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2022
@dims
Copy link
Member

dims commented Feb 17, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3fdbbb2 into kubernetes:master Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 17, 2022
@k8s-ci-robot
Copy link
Contributor

@marosset: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key k8s-staging-gmsa-webhook.yaml using file config/jobs/image-pushing/k8s-staging-gmsa-webhook.yaml

In response to this:

Signed-off-by: Mark Rossetti [email protected]

/hold
wait for kubernetes-sigs/windows-gmsa#59 to merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marosset marosset deleted the gmsa-post-submit-push-images branch February 17, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@spiffxp spiffxp Awaiting requested review from spiffxp

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

@dims dims

@spiffxp spiffxp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@marosset @dims @k8s-ci-robot @spiffxp