Updating makefiles so we can push staging images to gcr.io/k8s-staging/gmsa-webhook #59
Conversation
…g/gmsa-webhook Signed-off-by: Mark Rossetti <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/assign @jsturtevant @phillipsj |
|
@marosset: GitHub didn't allow me to assign the following users: phillipsj. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
After this merges I will make a PROW job to build these images |
…-staging/gmsa-webhook
….io/k8s-staging/gmsa-webhook
| - TAG=${_GIT_TAG} | ||
| - PULL_BASE_REF=${_PULL_BASE_REF} | ||
| args: | ||
| - cd admission-webhook && make release-staging |
There was a problem hiding this comment.
I am not familiar with the promotion flow here. This will push an image every time we merge a PR to main branch? Does the test-infra job then promote the image to the non-staging repository? How do we promote only on a tagged version?
We should run at least unit tests and one integration test before promoting.
There was a problem hiding this comment.
The test infra job triggers the workflow which pushes staging images to gcr.io/k8s-staging-gmsa-webhook.
We can configure the triggers for the test infra job but most of the jobs do run on every PR merge into main.
We don't have a workflow for promoting images at the moment.
There was a problem hiding this comment.
my guess is we probably want the workflow for promoting image to trigger on tag pushes or pushes to release branches.
yes this makes sense.
So the workflow here is:
- pr merges
- Prow post submit job triggers the cloudbuild which pushes to staging repository
- when we create tag image is promoted to official image (to be done in follow pr)
I guess we don't need the tests here then and looks like it common to simply build the image in the cloudbuild.yaml file but could we add a small section to the contributing readme so we have this documented?
There was a problem hiding this comment.
How about I add it to the release.md?
There was a problem hiding this comment.
I filed #60 and will document the release process in another PR.
The current release process is just a template and does not even reflect the process for releasing images to the old dockerhub account :(
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Signed-off-by: Mark Rossetti [email protected]
Updating our build files so we can push images to gcr.io/k8s-staging-gmsa-webhook from PROW jobs (which don't exist yet).
I'm adding
make release-stagingwhich will build and push the images to the staging repository.Running
make image_buildandmake image_pushwill continue to build/push images tosigwindowstools/k8s-windows-gmsa-webhook.