robots/commenter: add --include-locked flag #23029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions just like --include-archived and --include-closed. Added equivalent test cases, reordered a bit so the order is consistently "archived, closed, locked"
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
I was assuming this was going to push an image but I don't see a new one |
|
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-test-infra-push-prow/1419823923347853312 Ah, this is pushed to k8s-prow (why?) |
|
Opened #23032 to bump jobs to use this image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes something I just happened to notice while verifying #22997 as part of #12296
https://testgrid.k8s.io/sig-contribex-k8s-triage-robot#stale - the job is commenting, but it's also failing because it's unable to comment on a locked issue, e.g. https://storage.googleapis.com/kubernetes-jenkins/logs/ci-k8s-triage-robot-stale/1419722568809582592/build-log.txt
In this case the issue is being used as an announcements issue, so they don't want contributors to be able to comment on it.
Rather than add
is:unlockedto all of the queries, ignore locked issues by default. This is the same thing we do with--include-archivedand--include-closed.Added equivalent test cases, reordered a bit so the order is consistently "archived, closed, locked"