-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use k8s-triage-robot in lieu of fejta-bot for kubernetes issue/pr commenter jobs #12296
Comments
|
/assign Assigning it to myself to try to move this along in contribex |
Any reason not to use one of the existing robots? |
We need prow to react to the comments posted by these jobs, so it can't be @k8s-ci-robot. We could maybe use @k8s-github-robot, but I would prefer using a bot that has no privileges. |
You'll want to rename more than the account:
Things @fejta-bot does:
Naming is hard, WDYT of either of these?
|
/milestone v1.16 |
k8s-cuddle-bot |
+1 to k8s-triage-[ro]bot! |
+1 to k8s-triage-bot |
fajita-bot |
+1 to k8s-triage-robot. Since we have To be clear, this would be creating a new account instead of renaming the original one, right? I'm assuming @fejta would like to keep @fejta-bot around for testing, etc... @fejta can you confirm? :) |
/area github-management
I spoke offline with fejta last week and am confirming by proxy, as he's out this week |
I've squatted on http://github.com/k8s-triage-robot, what needs to happen now is:
note that fejta-bot is not a member of the org, doesn't have any privileges, doesn't need to have 2fa enabled; if we want that to change, I'd rather consider that out of scope here, and ask that those so motivated create a followup issue to |
Created #13683 to get the ball rolling
Do we know who created the avatar for @k8s-github-robot? It's pretty dope! |
👋 😄 |
/priority important-soon |
/reopen |
@spiffxp: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
Added the k8s-triage-robot token to k8s-infra-prow-build-trusted kubernetes/k8s.io#2389 Next step is to try a sample job to make sure it works, then we can migrate the fejta-bot jobs |
I originally posted more comments in the wrong issue (#11402) so I'm copy-pasting them here |
The test job is failing (whoops I must have missed the tab name): https://testgrid.k8s.io/sig-contribex-k8s-triage-robot#api-review-help It seems like bad credentials? https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-k8s-triage-robot-testcomment/1418328613631037440 So I logged into k8s-triage-robot, and sure enough, no personal access tokens at all. Created a new one, updated the secret, waiting for the next job run. Originally posted by @spiffxp in #11402 (comment) |
Originally posted by @spiffxp in #11402 (comment) |
Fixed the token, it needed The query also didn't include Originally posted by @spiffxp in #11402 (comment) |
Orrrr apparently github's search returned one issue the first time, and two the second. But that's it. Should see no more spam at this point. Opened #22997 to switch all the fejta-bot jobs over to k8s-triage-robot Originally posted by @spiffxp in #11402 (comment) |
https://github.com/issues?q=involves%3Ak8s-triage-robot+archived%3Afalse+sort%3Aupdated-desc+ - so the bot is definitely commenting now There are still some "failing" jobs on the dashboard
|
Opened a PR to bump jobs to use the latest commenter: I think because I tried re-running the other two jobs (since I can't re-trigger them), they tried and failed against the wrong cluster again, and their interval might have reset. In other words, may need to wait to sometime after 3pm PT to see if they go back to green |
/milestone v.122 |
@spiffxp: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone v1.22 |
@spiffxp: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Background: @fejta-bot automatically marks issues as stale/rotten and closes them if they don't have any activity for certain number of days. It is an unprivileged user and is not a member of any of the Kubernetes GitHub orgs.
While enabling fejta-bot automation across all Kubernetes GitHub orgs, it was suggested to rename it to something "official": https://groups.google.com/d/topic/kubernetes-dev/9ps8uNXJ10k/discussion
This issue is to track discussing renaming fejta-bot - what to rename it as or if we should use another account entirely - and making sure that this is rolled out across orgs.
/sig contributor-experience
/sig testing
/cc @cblecker @fejta @spiffxp
The text was updated successfully, but these errors were encountered: