Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csi-driver-smb: add new prow job to test external e2e tests #22013

Merged

Conversation

boddumanohar
Copy link
Contributor

with this kubernetes-csi/csi-driver-smb#254 PR, csi-driver-smb introduces kubernetes external e2e tests. To tests the external e2e tests, we will require a new job.

thanks,
Manohar.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 29, 2021
@boddumanohar boddumanohar force-pushed the csi-driver-smb-external-e2e branch from 199e029 to 72cb155 Compare April 29, 2021 05:51
@boddumanohar boddumanohar force-pushed the csi-driver-smb-external-e2e branch from 72cb155 to f7160ab Compare April 29, 2021 05:56
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, boddumanohar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 15c8222 into kubernetes:master Apr 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

@boddumanohar: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key csi-driver-smb-config.yaml using file config/jobs/kubernetes-csi/csi-driver-smb/csi-driver-smb-config.yaml

In response to this:

with this kubernetes-csi/csi-driver-smb#254 PR, csi-driver-smb introduces kubernetes external e2e tests. To tests the external e2e tests, we will require a new job.

thanks,
Manohar.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants