Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add K8s external storage E2E tests #254

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Add K8s external storage E2E tests #254

merged 1 commit into from
Apr 29, 2021

Conversation

boddumanohar
Copy link
Contributor

What type of PR is this?
add external e2e tests

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @boddumanohar. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 24, 2021
@boddumanohar boddumanohar changed the title add external e2e tests Add K8s external storage E2E tests Apr 24, 2021
@coveralls
Copy link

coveralls commented Apr 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 795601481

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.675%
Totals Coverage Status
Change from base Build 792391379: 0.0%
Covered Lines: 696
Relevant Lines: 803
💛 - Coveralls

@boddumanohar
Copy link
Contributor Author

I am seeing 3 failures will debug tomorrow:

Summarizing 3 Failures:

[Fail] External Storage [Driver: smb.csi.k8s.io] [Testpattern: Dynamic PV (filesystem volmode)] multiVolume [Slow] [Measurement] should concurrently access the single volume from pods on different node
/workspace/anago-v1.19.0-rc.4.197+594f888e19d8da/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/storage/utils/utils.go:85

[Fail] External Storage [Driver: smb.csi.k8s.io] [Testpattern: Dynamic PV (filesystem volmode)] multiVolume [Slow] [Measurement] should access to two volumes with the same volume mode and retain data across pod recreation on the same node
/workspace/anago-v1.19.0-rc.4.197+594f888e19d8da/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/storage/utils/utils.go:85

[Fail] External Storage [Driver: smb.csi.k8s.io] [Testpattern: Dynamic PV (filesystem volmode)] multiVolume [Slow] [Measurement] should access to two volumes with the same volume mode and retain data across pod recreation on different node
/workspace/anago-v1.19.0-rc.4.197+594f888e19d8da/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/storage/utils/utils.go:85

Ran 6 of 5428 Specs in 132.785 seconds
FAIL! -- 3 Passed | 3 Failed | 0 Pending | 5422 Skipped

@boddumanohar boddumanohar mentioned this pull request Apr 29, 2021
Merged
@boddumanohar boddumanohar force-pushed the external-e2e-tests branch 2 times, most recently from 4f82c8a to 4bb4d94 Compare April 29, 2021 06:13
andyzhangx
andyzhangx reviewed Apr 29, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2021
@boddumanohar boddumanohar force-pushed the external-e2e-tests branch 2 times, most recently from 0bcec6e to 4e78950 Compare April 29, 2021 09:17
andyzhangx
andyzhangx approved these changes Apr 29, 2021
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, boddumanohar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6ba0258 into kubernetes-csi:master Apr 29, 2021
@boddumanohar boddumanohar mentioned this pull request Jun 3, 2021
Closed
andyzhangx added a commit to andyzhangx/csi-driver-smb that referenced this pull request Jun 5, 2024
@andyzhangx
Squashed 'release-tools/' changes from b54c1ba49..f40f0ccd4
3a89671 
f40f0ccd4 Merge pull request kubernetes-csi#256 from solumath/master
cfa92106c Instruction update
379a1bb9b Merge pull request kubernetes-csi#255 from humblec/sidecar-md
a5667bbbb fix typo in sidecar release process
49676850e Merge pull request kubernetes-csi#254 from bells17/add-github-actions
d9bd160c2 Update skip list in codespell GitHub Action
adb3af9df Merge pull request kubernetes-csi#252 from bells17/update-go-version
f5aebfc9f Add GitHub Actions workflows
b82ee3888 Merge pull request kubernetes-csi#253 from bells17/fix-typo
c31745621 Fix typo
0a7850561 Bump to Go 1.22.3
edd89ad58 Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck
043fd0991 Add test-logcheck target
d7535ae0c Merge pull request kubernetes-csi#250 from jsafrane/go-1.22
b52e7ad35 Update go to 1.22.2
14fdb6f66 Merge pull request kubernetes-csi#247 from msau42/prow
dc4d0ae20 Merge pull request kubernetes-csi#249 from jsafrane/use-go-version
e681b170e Use .go-version to get Kubernetes go version
9b4352e9f Update release playbook
c7bb972cc Fix release notes script to use fixed tags
463a0e9f5 Add script to update specific go modules

git-subtree-dir: release-tools
git-subtree-split: f40f0ccd458f2d4555e3ca98d69b5a984bae0f14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boddumanohar @k8s-ci-robot @coveralls @andyzhangx