-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image/gcp: add job to build k8s-staging-cloud-provider-gcp image #21374
image/gcp: add job to build k8s-staging-cloud-provider-gcp image #21374
Conversation
if we don't want to be attached to a tag/release branch we can add a variant.yaml and then set the image tag in that file, so the prow job can only run if that file and/or other related changed. |
- name: post-gcp-compute-persistent-disk-csi-driver-push-images | ||
cluster: k8s-infra-prow-build-trusted | ||
annotations: | ||
testgrid-dashboards: provider-gcp-filestore-csi-driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want the pd csi testgrids at https://testgrid.k8s.io/provider-gcp-compute-persistent-disk-csi-driver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did not know that one ( ERR_TOO_MANY_DASHBOARDS 😂 )
updated
05c06bf
to
8fe4751
Compare
8fe4751
to
bc277c8
Compare
/lgtm I presume a test-infra owner has to approve etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cpanato: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
this PR add the prow job to build the
k8s-staging-cloud-provider-gcp
image as part of the effort described in kubernetes/k8s.io#152Related PR that adds the cloudbuild config: kubernetes-sigs/gcp-compute-persistent-disk-csi-driver#724
for more context slack 🧵 https://kubernetes.slack.com/archives/C09QZFCE5/p1615563067038600
/assign @msau42 @mattcary @spiffxp