Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudbuild config to build gcp-compute-persistent-disk-csi-driver image #724

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Add cloudbuild config to build gcp-compute-persistent-disk-csi-driver image #724

merged 2 commits into from
Mar 16, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 15, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

As part of the effort described in this issue we are deprecating the gcr.io/gke-release and the image gcr.io/gke-release/gcp-compute-persistent-disk-csi-driver does not exist in other registries. So we need to build that and push to a new registry.

We will use gcr.io/k8s-staging-cloud-provider-gcp to push the images and This PR add the cloudbuild to generate and push the image.

for more context see the slack 🧵 https://kubernetes.slack.com/archives/C09QZFCE5/p1615563067038600bump

  • Also bump the go version to the lastest 1.13 available

k/test-infra PR to add the prow job: kubernetes/test-infra#21374

/assign @spiffxp @msau42 @mattcary

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add cloudbuild config to build gcp-compute-persistent-disk-csi-driver image

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 15, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 15, 2021
@cpanato
Copy link
Member Author

cpanato commented Mar 15, 2021

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

@cpanato
Copy link
Member Author

cpanato commented Mar 15, 2021

/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration

@mattcary
Copy link
Contributor

Note the integration failure is due to #721 for which a fix is on its way.

cloudbuild.yaml Show resolved Hide resolved
cloudbuild.yaml Outdated Show resolved Hide resolved
cloudbuild.yaml Outdated Show resolved Hide resolved
@cpanato
Copy link
Member Author

cpanato commented Mar 16, 2021

testing this cloudbuild on my GCP account, and everything worked fine

@mattcary
Copy link
Contributor

/lgtm

thanks tons for helping with this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2021
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@spiffxp
Copy link
Member

spiffxp commented Mar 16, 2021

/assign @mattcary @msau42
For the /approve, I don't have rights here

@mattcary
Copy link
Contributor

Oops I can never keep track of when I have to lgtm and when I have to approve. Thanks @spiffxp

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, mattcary, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit b72afce into kubernetes-sigs:master Mar 16, 2021
@cpanato cpanato deleted the GH-1525-csi-driver branch March 17, 2021 08:02
@cpanato
Copy link
Member Author

cpanato commented Mar 17, 2021

job ran successfully (https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-gcp-compute-persistent-disk-csi-driver-push-images/1371915861887029248) and the master tag is available: docker pull gcr.io/k8s-staging-cloud-provider-gcp/gcp-compute-persistent-disk-csi-driver:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants