-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloudbuild config to build gcp-compute-persistent-disk-csi-driver image #724
Add cloudbuild config to build gcp-compute-persistent-disk-csi-driver image #724
Conversation
/test pull-gcp-compute-persistent-disk-csi-driver-e2e |
/test pull-gcp-compute-persistent-disk-csi-driver-kubernetes-integration |
Note the integration failure is due to #721 for which a fix is on its way. |
testing this cloudbuild on my GCP account, and everything worked fine |
/lgtm thanks tons for helping with this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
Oops I can never keep track of when I have to lgtm and when I have to approve. Thanks @spiffxp /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, mattcary, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
job ran successfully (https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-gcp-compute-persistent-disk-csi-driver-push-images/1371915861887029248) and the master tag is available: |
Add cloudbuild for gcp-compute-persistent-disk-csi-drive - cherry pick #724
What type of PR is this?
/kind feature
What this PR does / why we need it:
As part of the effort described in this issue we are deprecating the
gcr.io/gke-release
and the imagegcr.io/gke-release/gcp-compute-persistent-disk-csi-driver
does not exist in other registries. So we need to build that and push to a new registry.We will use
gcr.io/k8s-staging-cloud-provider-gcp
to push the images and This PR add the cloudbuild to generate and push the image.for more context see the slack 🧵 https://kubernetes.slack.com/archives/C09QZFCE5/p1615563067038600bump
k/test-infra
PR to add the prow job: kubernetes/test-infra#21374/assign @spiffxp @msau42 @mattcary
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: