add e2e external test as a required job in CI

[AndyXiangLi]

Make migration test as a required step.

Add external e2e test job

[k8s-ci-robot]

Welcome @AndyXiangLi!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @AndyXiangLi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wongma7]

/ok-to-test
/lgtm

thanks!! let's merge this first

[AndyXiangLi]

@wongma7 make test-e2e-external is not there in our Makefile, will that introduce any issue if we merge the CI change first?

[wongma7]

@AndyXiangLi yes, but I was thinking we could merge kubernetes-sigs/aws-ebs-csi-driver#726 immediately after.

Another option is to mark this "always_run: false".

Then when we want to test kubernetes-sigs/aws-ebs-csi-driver#726, we can comment "/test pull-aws-ebs-csi-driver-external-test-latest". Then after we merge 726, come back here and mark always_run: true.

[AndyXiangLi]

@wongma7 I'm thinking we can merge 726 first, this should not break anything as no consumer of test-e2e-external and other tests should remain same, and then merge this one right after

[wongma7]

okay, sgtm

[wongma7]

/hold

/lgtm

waiting for kubernetes-sigs/aws-ebs-csi-driver#726

[wongma7]

/hold cancel

[wongma7]

/assign @gyuho

could you approve this. Thanks!

I'll get myself added to approvers soon. Anyone in ebs OWNERS should also be approver here...

PR to add myself as approver: #20758

[wongma7]

Here is the PR to add myself to approvers: https://github.com/kubernetes/test-infra/pull/20758/files

[AndyXiangLi]

Hi @gyuho Any updates on this?

[ayberk]

/approve
/lgtm

[gyuho]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyXiangLi, ayberk, gyuho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• config/jobs/kubernetes-sigs/aws-ebs-csi-driver/OWNERS [gyuho]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@AndyXiangLi: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

• key aws-ebs-csi-driver-presubmits.yaml using file config/jobs/kubernetes-sigs/aws-ebs-csi-driver/aws-ebs-csi-driver-presubmits.yaml

In response to this:

Make migration test as a required step.

Add external e2e test job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.