Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run kubernetes e2e tests without migration #406

Closed
jsafrane opened this issue Nov 11, 2019 · 13 comments
Closed

Run kubernetes e2e tests without migration #406

jsafrane opened this issue Nov 11, 2019 · 13 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@jsafrane
Copy link
Contributor

E2E tests for CSI migration are added in #294. We need the same e2e tests also with plain CSI driver, without migration.

In other words, install the driver and run upstream e2e tests with the CSI driver (with the driver in StorageClass, no migration), as described in https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/external/README.md.

Since most of the work (cluster & driver installation) is already done, it could be a simple ginkgo command in a new prow job.

/feature

@leakingtapan
Copy link
Contributor

leakingtapan commented Nov 11, 2019

Another additional work is the current testing script is not that configurable for tuning feature gates (hard coded to enabled migration). I have already written a new framework (which is more configurable) for e2e testing, I need make changes to create 1.16+ cluster (due to kops is not yet officially released to 1.16+ cluster)

The other idea is we can combine the upstream e2e testing suites with the existing e2e suites instead of creating new make target. So that it will be run as part of make testing-e2e-single-az or make testing-e2e-multi-az

@leakingtapan
Copy link
Contributor

leakingtapan commented Nov 12, 2019

due to kops is not yet officially released to 1.16+ cluster

I just switched to use kops 1.16 alpha: #409

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2020
@leakingtapan
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 24, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 24, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 23, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ayberk
Copy link
Contributor

ayberk commented Jan 26, 2021

/reopen
/lifecycle frozen

@k8s-ci-robot
Copy link
Contributor

@ayberk: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 26, 2021
@AndyXiangLi
Copy link
Contributor

We already add external e2e test in PR
This can be closed when upstream test-infra update our CI kubernetes/test-infra#20747

@ayberk
Copy link
Contributor

ayberk commented Feb 9, 2021

OK let me close this one. I'll get that merged today.

/close

@k8s-ci-robot
Copy link
Contributor

@ayberk: Closing this issue.

In response to this:

OK let me close this one. I'll get that merged today.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

6 participants