Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-node: Clean up some testgrid annotations and config suffixes #15921

Merged
merged 2 commits into from
Jan 17, 2020
Merged

sig-node: Clean up some testgrid annotations and config suffixes #15921

merged 2 commits into from
Jan 17, 2020

Conversation

justaugustus
Copy link
Member

(cp from #15875)

  • Remove sig-node-cri-1.12 dashboard
    Dashboard will no longer be in use once we remove the 1.14 release jobs.
  • Fix testgrid annotations and suffixes for node-kubelet jobs

/assign @dchen1107 @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 15, 2020
@justaugustus justaugustus mentioned this pull request Jan 15, 2020
Closed
@justaugustus
Copy link
Member Author

/assign @Katharine @chases2

FWIW, @dchen1107 has already approved these changes here: #15875 (comment)

chases2
chases2 approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@chases2 chases2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold
(to address/acknowledge comments)

config/jobs/kubernetes/sig-node/node-kubelet.yaml Outdated
@@ -4,7 +4,7 @@ periodics:
annotations:
fork-per-release: "true"
fork-per-release-periodic-interval: 1h 2h 6h 24h
fork-per-release-generic-suffix: "true"
testgrid-create-test-group: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestGrid (specifically Configurator) will automatically create a test group for you if the job either:

  • is a postsubmit or periodic, or
  • has a testgrid-dashboards entry already

These lines don't hurt anything, but they're redundant.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 17, 2020
@chases2
Copy link
Contributor

chases2 commented Jan 17, 2020

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2020
@justaugustus
sig-node: Remove sig-node-cri-1.12 dashboard
9838e5b 
Dashboard will no longer be in use once we remove the 1.14 release jobs.

Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus
sig-node: Fix testgrid annotations and suffixes for node-kubelet jobs
c45c54a 
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020
@justaugustus
Copy link
Member Author

Fixed up based on @chases2's suggestion. Thanks!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6d7d9af into kubernetes:master Jan 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 17, 2020
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key node-kubelet.yaml using file config/jobs/kubernetes/sig-node/node-kubelet.yaml
  • key 1.14.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.14.yaml
  • key 1.15.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.15.yaml
  • key 1.16.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.16.yaml
  • key 1.17.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.17.yaml

In response to this:

(cp from #15875)

  • Remove sig-node-cri-1.12 dashboard
    Dashboard will no longer be in use once we remove the 1.14 release jobs.
  • Fix testgrid annotations and suffixes for node-kubelet jobs

/assign @dchen1107 @derekwaynecarr

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 chases2 approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@Katharine Katharine

@chases2 chases2

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @chases2 @k8s-ci-robot @Katharine @derekwaynecarr @dchen1107