releng: Remove 1.14 jobs, shift beta version marker, and regenerate tests #15875

justaugustus · 2020-01-12T23:12:04Z

Fixes: #15514, fixes: kubernetes/kubernetes#87111 (cc: @kubernetes/ci-signal)

Remove Kubernetes 1.14 jobs
Update generated tests for pre-1.18
Update existing branch job version refs using config-rotator
provider/gcp: Comment out gce-device-plugin-gpu-beta dashboard tab

For Release Engineering bits:
/assign @Katharine @tpepper @cpanato @saschagrunert

cc: @kubernetes/release-engineering
/priority critical-urgent

justaugustus · 2020-01-13T00:24:46Z

Ughhhh. I'm gaining an even deeper appreciation for the work @Katharine did to get us to the point we are at today with the release branches and job generation.

I think I know what this next failure is about. Time to poke at the config-rotator.

neolit123 · 2020-01-13T00:41:28Z

LGTM on the config/jobs/kubernetes/sig-cluster-lifecycle/* changes.
i have a PR open for this here:
#15576

but was waiting for 1.17.1 to come out. thanks.

justaugustus · 2020-01-13T01:01:35Z

This is about to fail again. Here's what I got locally:

$ time bazel test //config/...
INFO: Analyzed 3 targets (1 packages loaded, 981 targets configured).
INFO: Found 3 test targets...
FAIL: //config/tests/testgrids:go_default_test (see /home/augustus/.cache/bazel/_bazel_augustus/e12d25d9a9ef0205fe09fd32cbe17129/execroot/io_k8s_test_infra/bazel-out/k8-fastbuild/testlogs/config/tests/testgrids/go_default_test/test.log)
INFO: From Testing //config/tests/testgrids:go_default_test:
==================== Test output for //config/tests/testgrids:go_default_test:
--- FAIL: TestConfig (0.01s)
    config_test.go:228: Dashboard wg-resource-management, tab gce-device-plugin-gpu-1.12: - Testgroup ci-kubernetes-e2e-gce-device-plugin-gpu-beta must be defined first
    config_test.go:187: Dashboard sig-node-cri-1.12: - Must have more than one dashboardtab
    config_test.go:328: Testgroup ci-kubernetes-node-kubelet-features-beta - defined but not used in any dashboards.
    config_test.go:328: Testgroup ci-kubernetes-node-kubelet-beta - defined but not used in any dashboards.
    config_test.go:333: Note: Testgroups are automatically defined for postsubmits and periodics.
    config_test.go:334: Testgroups can be added to a dashboard either by using the `testgrid-dashboards` annotation on the prowjob, or by adding them to testgrid/config.yaml
--- FAIL: TestKubernetesProwInstanceJobsMustHaveMatchingTestgridEntries (1.90s)
    config_test.go:436: Testgrid group ci-kubernetes-node-kubelet-beta does not have a matching jenkins or prow job
    config_test.go:436: Testgrid group ci-kubernetes-node-kubelet-features-beta does not have a matching jenkins or prow job
FAIL
================================================================================
INFO: Elapsed time: 5.614s, Critical Path: 2.30s
INFO: 2 processes: 2 linux-sandbox.
INFO: Build completed, 1 test FAILED, 2 total actions
//config/tests/jobs:go_default_test                             (cached) PASSED in 3.1s
//config/tests/lint:go_default_test                             (cached) PASSED in 1.1s
//config/tests/testgrids:go_default_test                                 FAILED in 2.1s
  /home/augustus/.cache/bazel/_bazel_augustus/e12d25d9a9ef0205fe09fd32cbe17129/execroot/io_k8s_test_infra/bazel-out/k8-fastbuild/testlogs/config/tests/testgrids/go_default_test/test.log

Executed 1 out of 3 tests: 2 tests pass and 1 fails locally.
INFO: Build completed, 1 test FAILED, 2 total actions

real	0m5.650s
user	0m0.017s
sys	0m0.017s

Looks like there are some more old jobs to prune/reconfigure.

justaugustus · 2020-01-13T03:54:59Z

PR now includes a cleanup of the testgrid annotations for node-kubelet jobs, so I'm tagging SIG Node for awareness.

cc: @dchen1107 @derekwaynecarr

cpanato

/lgtm

alejandrox1 · 2020-01-13T16:27:44Z

@justaugustus why are 1.14 jobs being removed at this time?

justaugustus · 2020-01-17T01:45:06Z

(#15921 is the last one to rebase out of this, once it's approved.)

justaugustus · 2020-01-17T23:02:18Z

All of the commits that I've peeled off of this PR have merged as individual PRs (list above).
Once we complete the patch release set (1.17 - 1.14, ref: kubernetes/kubernetes#86182) next week, we'll be able to merge this and formally turn off tests for 1.14.

cc: @tpepper
/unassign @aojea @dchen1107

justaugustus · 2020-01-19T06:55:43Z

(This should merge after #15564.)

saschagrunert

/lgtm

k8s-ci-robot · 2020-01-20T10:08:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert
To complete the pull request process, please assign katharine
You can assign the PR to them by writing /assign @katharine in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

~~config/jobs/kubernetes/generated/OWNERS~~ [justaugustus]
~~config/jobs/kubernetes/sig-release/OWNERS~~ [justaugustus]
config/testgrids/OWNERS
~~releng/OWNERS~~ [justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Stephen Augustus <[email protected]>

k8s-ci-robot · 2020-01-21T19:48:10Z

New changes are detected. LGTM label has been removed.

justaugustus · 2020-01-21T19:49:14Z

Rebased now that #15564 is merged.
This is ready for approval.

/hold cancel

k8s-ci-robot · 2020-01-21T19:55:45Z

@justaugustus: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-test-infra-bazel	`81d2937`	link	`/test pull-test-infra-bazel`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

justaugustus · 2020-01-21T20:36:55Z

Aha, my comment on another PR rears its' head again:

(Looks like some additional tests were enabled recently to enforce OWNERS and descriptions for certain job types. Some of those are my jobs, so I'll fix some of that up.)

I'm not sure why this hasn't failed on other PRs (that I've seen), but I can work on fixing it up here.

justaugustus · 2020-02-13T15:33:09Z

Given that the branch cut is around the corner and I'd like the Branch Managers (@cpanato, @saschagrunert) to get familiar with the process, we'll continue as-is and I'll close this out.

/close

k8s-ci-robot · 2020-02-13T15:33:11Z

@justaugustus: Closed this PR.

In response to this:

Given that the branch cut is around the corner and I'd like the Branch Managers (@cpanato, @saschagrunert) to get familiar with the process, we'll continue as-is and I'll close this out.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-02-13T15:33:17Z

@justaugustus: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot assigned aojea, BenTheElder, cpanato and Katharine Jan 12, 2020

k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jan 12, 2020

k8s-ci-robot assigned saschagrunert and tpepper Jan 12, 2020

k8s-ci-robot requested review from chases2 and cpanato January 12, 2020 23:13

This was referenced Jan 12, 2020

sig-release-1.14-blocking#bazel-test-1.14 failing #15514

Closed

[Failing Test] bazel-build-1.14 (periodic-kubernetes-bazel-build-1-14) kubernetes/kubernetes#87111

Closed

justaugustus force-pushed the 114-rm branch from 0f63618 to f9f169f Compare January 12, 2020 23:47

neolit123 mentioned this pull request Jan 13, 2020

[Failing Test] Release branch tests are failing to extract latest Kubernetes CI builds kubernetes/kubernetes#86182

Closed

justaugustus mentioned this pull request Jan 13, 2020

Assess version markers used in release-branch job configs kubernetes/sig-release#850

Open

9 tasks

cpanato approved these changes Jan 13, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2020

justaugustus force-pushed the 114-rm branch from 8e05bbe to ffc1df1 Compare January 13, 2020 19:05

justaugustus force-pushed the 114-rm branch 2 times, most recently from f1046db to 928518f Compare January 17, 2020 01:40

justaugustus changed the title ~~releng: Remove 1.14 jobs, tweak generator template, update OWNERS, add 1.17 kind jobs~~ releng: Remove 1.14 jobs, shift beta version marker, and regenerate tests Jan 17, 2020

justaugustus force-pushed the 114-rm branch from 928518f to 0e95f49 Compare January 17, 2020 22:48

k8s-ci-robot unassigned aojea and dchen1107 Jan 17, 2020

justaugustus mentioned this pull request Jan 19, 2020

releng: Remove bazel version markers #15612

Merged

droslean mentioned this pull request Jan 20, 2020

[Failing Test] Failing Generated Jobs (sig-release-generated) kubernetes/kubernetes#87376

Closed

saschagrunert approved these changes Jan 20, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2020

justaugustus added 4 commits January 21, 2020 14:25

releng: Remove Kubernetes 1.14 jobs

45b6c03

Signed-off-by: Stephen Augustus <[email protected]>

releng: Update generated tests for 1.18

5ac6b69

Signed-off-by: Stephen Augustus <[email protected]>

releng: Update existing branch job version refs using config-rotator

10bd89d

Signed-off-by: Stephen Augustus <[email protected]>

provider/gcp: Comment out gce-device-plugin-gpu-beta dashboard tab

81d2937

Signed-off-by: Stephen Augustus <[email protected]>

justaugustus force-pushed the 114-rm branch from 0e95f49 to 81d2937 Compare January 21, 2020 19:48

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2020

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020

k8s-ci-robot closed this Feb 13, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

releng: Remove 1.14 jobs, shift beta version marker, and regenerate tests #15875

releng: Remove 1.14 jobs, shift beta version marker, and regenerate tests #15875

justaugustus commented Jan 12, 2020 •

edited

Loading

justaugustus commented Jan 13, 2020

neolit123 commented Jan 13, 2020 •

edited

Loading

justaugustus commented Jan 13, 2020

justaugustus commented Jan 13, 2020

cpanato left a comment

alejandrox1 commented Jan 13, 2020

justaugustus commented Jan 17, 2020

justaugustus commented Jan 17, 2020 •

edited

Loading

justaugustus commented Jan 19, 2020

saschagrunert left a comment

k8s-ci-robot commented Jan 20, 2020

k8s-ci-robot commented Jan 21, 2020

justaugustus commented Jan 21, 2020

k8s-ci-robot commented Jan 21, 2020

justaugustus commented Jan 21, 2020 •

edited

Loading

justaugustus commented Feb 13, 2020

k8s-ci-robot commented Feb 13, 2020

k8s-ci-robot commented Feb 13, 2020

releng: Remove 1.14 jobs, shift beta version marker, and regenerate tests #15875

releng: Remove 1.14 jobs, shift beta version marker, and regenerate tests #15875

Conversation

justaugustus commented Jan 12, 2020 • edited Loading

justaugustus commented Jan 13, 2020

neolit123 commented Jan 13, 2020 • edited Loading

justaugustus commented Jan 13, 2020

justaugustus commented Jan 13, 2020

cpanato left a comment

Choose a reason for hiding this comment

alejandrox1 commented Jan 13, 2020

justaugustus commented Jan 17, 2020

justaugustus commented Jan 17, 2020 • edited Loading

justaugustus commented Jan 19, 2020

saschagrunert left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jan 20, 2020

k8s-ci-robot commented Jan 21, 2020

justaugustus commented Jan 21, 2020

k8s-ci-robot commented Jan 21, 2020

justaugustus commented Jan 21, 2020 • edited Loading

justaugustus commented Feb 13, 2020

k8s-ci-robot commented Feb 13, 2020

k8s-ci-robot commented Feb 13, 2020

justaugustus commented Jan 12, 2020 •

edited

Loading

neolit123 commented Jan 13, 2020 •

edited

Loading

justaugustus commented Jan 17, 2020 •

edited

Loading

justaugustus commented Jan 21, 2020 •

edited

Loading