kops: pass the --host to the test suite #15058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few tests that require this to be directly passed.
k8s-ci-robot
added
cncf-cla: yes
|
/assign @feiskyer |
|
Thanks @rifelpet - looks great. Some of my code in here, so I normally shouldn't self approve, except that the other PR also has lgtm, so I think it's OK. /approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: justinsb, rifelpet The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few tests that require this to be directly passed.
This extends #14989, fixing a merge conflict. There seems to be no activity on that PR and it is causing test failures which are blocking Kops PRs from getting merged, so I thought it was important enough to rebase myself and open a separate PR. If that isn't acceptable please let me know.