Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extraneous document separator causing failures applying addons #7857

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Remove extraneous document separator causing failures applying addons #7857

merged 1 commit into from
Nov 4, 2019
+1 −1

Conversation

ripta
Copy link
Contributor

@ripta ripta commented Oct 30, 2019

Attempting to use kops 1.15.0-beta.1 with AWS VPC CNI plugin (the networking value amazon-vpc-routed-eni) causes these errors on the masters:

error: error validating "k8s-1.12.yaml": error validating data: [apiVersion not set, kind not set]; if you choose to ignore these errors, turn validation off with --validate=false

in fact, new clusters do not even come up healthy in my tests: the masters never reach Ready status.

This tiny change removes --- from the AWS VPC CNI addon, which directly addresses the above error. Upon fix, the masters showed Ready in the order of minutes.

Fixes #7805

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @ripta. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2019
@ripta ripta force-pushed the fix-aws-vpc-cni-addon branch from ec6b865 to a009ea5 Compare October 30, 2019 17:50
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Oct 30, 2019
@ripta
Copy link
Contributor Author

ripta commented Oct 30, 2019

/assign @mikesplain

@rifelpet
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2019
@mikesplain
Copy link
Contributor

Seriously lol? Thanks @ripta, great find.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2019
@justinsb
Copy link
Member

justinsb commented Nov 3, 2019

Thanks @ripta

/approve
/lgtm
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, mikesplain, ripta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justinsb,mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zetaab
Copy link
Member

zetaab commented Nov 3, 2019

@justinsb aws e2e is currently broken, none of those tests will pass. See kubernetes/test-infra#15058

@zetaab
Copy link
Member

zetaab commented Nov 4, 2019

/test pull-kops-e2e-kubernetes-aws

3 similar comments
@rifelpet
Copy link
Member

rifelpet commented Nov 4, 2019

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

rifelpet commented Nov 4, 2019

/test pull-kops-e2e-kubernetes-aws

@rifelpet
Copy link
Member

rifelpet commented Nov 4, 2019

/test pull-kops-e2e-kubernetes-aws

@k8s-ci-robot k8s-ci-robot merged commit 4c4d133 into kubernetes:master Nov 4, 2019
@rifelpet rifelpet mentioned this pull request Nov 4, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 6, 2019
@k8s-ci-robot
Merge pull request #7877 from rifelpet/automated-cherry-pick-of-#7857…
5859928 
…-origin-release-1.15

Automated cherry pick of #7857: Remove extraneous document separator causing failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet Awaiting requested review from rifelpet

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@justinsb justinsb

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addon yaml file saved to s3 as invalid yaml
6 participants
@ripta @k8s-ci-robot @rifelpet @mikesplain @justinsb @zetaab