Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kops jobs to experimental #14190

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Move kops jobs to experimental #14190

merged 1 commit into from
Sep 4, 2019

Conversation

mikesplain
Copy link
Contributor

@mikesplain mikesplain commented Sep 4, 2019 •
edited
Loading

Kops is running into a number of testing issues and we believe running different versions of bazel may be a cause. This PR moves all kops jobs to experimental containers, since all but 2 were currently using experimental.

For more info: kubernetes/kops#7508 (comment)

Or if anyone has guidance on which should be experimental vs master, that would be very much appreciated too. Thanks so much!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2019
@mikesplain
Copy link
Contributor Author

/assign @justinsb

@mikesplain mikesplain mentioned this pull request Sep 4, 2019
Merged
@chases2
Copy link
Contributor

chases2 commented Sep 4, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3adad46c1433be63a8efc76c4a702865f1e536d6

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2019
@mikesplain mikesplain force-pushed the move_kops_jobs_to_experimental branch from 3d42ac2 to 8ea5171 Compare September 4, 2019 18:32
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2019
@mikesplain
Copy link
Contributor Author

Conflict resolved, sorry about that @chases2.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2c30366f077f4bbfe961a91874a3cc36bc12ca6a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 12fcd80 into kubernetes:master Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

@mikesplain: Updated the job-config configmap in namespace default using the following files:

  • key kops-config.yaml using file config/jobs/kubernetes/kops/kops-config.yaml

In response to this:

Kops is running into a number of testing issues and we believe running different versions of bazel may be a cause. This PR moves all kops jobs to experimental containers, since all but 2 were currently using experimental.

For more info: kubernetes/kops#7508 (comment)

Or if anyone has guidance on which should be experimental vs master, that would be very much appreciated too. Thanks so much!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Sep 4, 2019
@mikesplain mikesplain deleted the move_kops_jobs_to_experimental branch September 4, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 chases2 approved these changes

@chrislovecnm chrislovecnm Awaiting requested review from chrislovecnm

Assignees

@justinsb justinsb

@chases2 chases2

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
4 participants
@mikesplain @chases2 @k8s-ci-robot @justinsb