Update rules_docker with python2 workaround

[rifelpet]

The kops-postsubmit jobs are currently failing with a python interpreter issue. See bazelbuild/rules_docker#842 for more info and bazelbuild/rules_docker#580 for tracking the long term fix.

Also updating the docker builds to use the same go version as #7499

/assign @justinsb

[rifelpet]

Hm I'm not sure why the e2e protokube build is failing

W0903 14:02:09.715] Traceback (most recent call last):
W0903 14:02:09.716]   File "/root/.cache/bazel/_bazel_prow/ae5d1f01453377487c630b230ced7d61/sandbox/linux-sandbox/44/execroot/__main__/bazel-out/host/bin/external/io_bazel_rules_docker/container/build_tar.runfiles/io_bazel_rules_docker/container/build_tar.py", line 449, in <module>
W0903 14:02:09.717]     main(FLAGS(sys.argv))
W0903 14:02:09.717]   File "/root/.cache/bazel/_bazel_prow/ae5d1f01453377487c630b230ced7d61/sandbox/linux-sandbox/44/execroot/__main__/bazel-out/host/bin/external/io_bazel_rules_docker/container/build_tar.runfiles/io_bazel_rules_docker/container/build_tar.py", line 402, in main
W0903 14:02:09.718]     with TarFile(FLAGS.output, FLAGS.directory, FLAGS.compression, FLAGS.root_directory) as output:
W0903 14:02:09.718]   File "/root/.cache/bazel/_bazel_prow/ae5d1f01453377487c630b230ced7d61/sandbox/linux-sandbox/44/execroot/__main__/bazel-out/host/bin/external/io_bazel_rules_docker/container/build_tar.runfiles/io_bazel_rules_docker/container/build_tar.py", line 130, in __enter__
W0903 14:02:09.718]     default_mtime=0
W0903 14:02:09.719] TypeError: __init__() got an unexpected keyword argument 'default_mtime'
W0903 14:02:09.756] Target //images:protokube.tar failed to build 

https://github.com/bazelbuild/rules_docker/blob/v0.9.0/container/build_tar.py#L126-L131

https://github.com/bazelbuild/bazel/blob/0.29.0/tools/build_defs/pkg/archive.py#L109-L113

[mikesplain]

Yeah... I've tested this upgrade a few times and been unable to get past that :/

[mikesplain]

/retest

[mikesplain]

Hoping #7511 may help this... So close!

[rifelpet]

I came across this test job with the same error which is from this PR

[rifelpet]

@mikesplain @justinsb I determined the cause of this failure. The e2e job is configured to use the gcr.io/k8s-testimages/kubekins-e2e:v20190703-1f4d616-master image:

https://github.com/kubernetes/test-infra/blob/5a60bc453fcb31b3b22a7ba7a3e2a9ae33acdd64/config/jobs/kubernetes/kops/kops-config.yaml#L71

which only has bazel 0.23.2. Other jobs are using an experimental image:

https://github.com/kubernetes/test-infra/blob/5a60bc453fcb31b3b22a7ba7a3e2a9ae33acdd64/config/jobs/kubernetes/kops/kops-config.yaml#L152

which has bazel 0.26.0.

I'm looking at GCR and the most recent master tag: v20190903-df3b2f0-master still has 0.23.2.

Is there a reason why some jobs use master and others use experimental? Can we update all of them use the latest v20190903-df3b2f0-experimental which has bazel 0.28.1? I can open a PR if desired.

[mikesplain]

Good catch @rifelpet, you know I noticed that but didn't think much of it. In fact they were even updated since you posted this. Now experimental points to bazel 0.28.1. I'm not sure why we have 2 different images, I'll take a look now.

[mikesplain]

Thanks so much for this @rifelpet, I opened kubernetes/test-infra#14190 to see if we can get everything on experimental or at least get some advice either way. Hopefully we can get this rolling today!

[rifelpet]

/test pull-kops-e2e-kubernetes-aws

[mikesplain]

Assuming this passes now, looks good to me!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikesplain, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mikesplain]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment