Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document default prowjob preset behavior #13956

Merged
merged 1 commit into from
Aug 17, 2019
Merged

document default prowjob preset behavior #13956

merged 1 commit into from
Aug 17, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Aug 17, 2019

Specifically

  • added an example to the prowjob docs
  • linked to the way we use it for GOPROXY in k8s-specific job docs
  • added unit tests for presets
  • since we use it for env vars, added a unit test to confirm env vars
    will conflict

Fixes #13665

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 17, 2019
@spiffxp spiffxp force-pushed the doc-default-preset branch from 7790a33 to ec0e95e Compare August 17, 2019 01:19
@spiffxp
document default prowjob preset behavior
c9b263a 
Specifically

- added an example to the prowjob docs
- linked to the way we use it for GOPROXY in k8s-specific job docs
- added unit tests for presets
- since we use it for env vars, added a unit test to confirm env vars
  will conflict
@spiffxp spiffxp force-pushed the doc-default-preset branch from ec0e95e to c9b263a Compare August 17, 2019 01:20
@spiffxp
Copy link
Member Author

spiffxp commented Aug 17, 2019

/cc @cblecker @cjwagner

@cblecker
Copy link
Member

/lgtm
/approve

Thanks for this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a933122a30b1e9f939f340d3125ed256d38bc5a1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7001522 into kubernetes:master Aug 17, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 17, 2019
@spiffxp spiffxp deleted the doc-default-preset branch August 17, 2019 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chases2 chases2 Awaiting requested review from chases2

@matthyx matthyx Awaiting requested review from matthyx

@cblecker cblecker Awaiting requested review from cblecker

@cjwagner cjwagner Awaiting requested review from cjwagner

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

prow: document default preset behaviour
3 participants
@spiffxp @cblecker @k8s-ci-robot