Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow: document default preset behaviour #13665

Closed
cblecker opened this issue Jul 29, 2019 · 3 comments · Fixed by #13956
Closed

prow: document default preset behaviour #13665

cblecker opened this issue Jul 29, 2019 · 3 comments · Fixed by #13956
Assignees
Labels
area/jobs area/prow Issues or PRs related to prow kind/documentation Categorizes issue or PR as related to documentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Milestone

Comments

@cblecker
Copy link
Member

What should be cleaned up or changed:
prow's preset functionality has the ability to have one or more "default" presets if you omit the labels field on a specific preset in the config.

example:

presets:
- env:
  - name: GOPROXY
    value: "https://proxy.golang.org"

This sets this env var for all jobs.

We need the following documentation locations updated:

We also need to ensure that there is sufficient test coverage for this use case (may or may not need additional test cases).

Provide any links for context:
#13648

@cblecker cblecker added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 29, 2019
@cblecker
Copy link
Member Author

/assign @spiffxp

@spiffxp
Copy link
Member

spiffxp commented Jul 29, 2019

/milestone v1.16
/area jobs
/area prow
/remove-kind cleanup
/kind documentation

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 29, 2019
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow kind/documentation Categorizes issue or PR as related to documentation. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 29, 2019
@spiffxp
Copy link
Member

spiffxp commented Aug 6, 2019

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jobs area/prow Issues or PRs related to prow kind/documentation Categorizes issue or PR as related to documentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants