krel/announce: ask for confirmation before sending the email #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
xmudrii
reviewed
Nov 15, 2021
|
@palnabarun still working on this one? |
The changes preserve the existing behavior when --nomock is not passed. Only when, --nomock is passed, a confirmation is seeked. Signed-off-by: Nabarun Pal <[email protected]>
palnabarun
force-pushed
the
krel/announce
branch
from
7e4ed4a to
00e5587
Compare
k8s-ci-robot
added
the
approved
|
@puerco -- Sorry, I completely forgot about it. I have made the requested changes. Please review again. |
xmudrii
approved these changes
Jan 27, 2022
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: palnabarun, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
The changes preserve the existing behaviour when
--nomockis not passed.Only when,
--nomockis passed, a confirmation is seeked.Which issue(s) this PR fixes:
Follow up on kubernetes/sig-release#1734
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/cc @kubernetes/release-engineering
/priority important-soon