Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sig-autoscaling: add teams for karpenter repo #4602

Merged
merged 3 commits into from
Nov 27, 2023
Merged

sig-autoscaling: add teams for karpenter repo #4602

merged 3 commits into from
Nov 27, 2023

Conversation

Priyankasaggu11929
Copy link
Member

Ref: #4562

/assign @kubernetes/owners

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 23, 2023
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 23, 2023
@Priyankasaggu11929
Copy link
Member Author

pull-org-test-all is failing with following error:

config_test.go:268: The following members of team karpenter-admins are not Kubernetes SIGs org members: gjtempleton, maciekpytel
config_test.go:268: The following members of team sig-autoscaling-leads are not Kubernetes SIGs org members: gjtempleton
config_test.go:268: The following members of team karpenter-maintainers are not Kubernetes SIGs org members: gjtempleton, maciekpytel

Both @gjtempleton and @MaciekPytel are existing members of the kubernetes org.

Adding them to the kubernetes-sigs org as well to fix the failing CI test.

@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Nov 23, 2023
Closed
@gjtempleton
Copy link
Member

Raised #4598 to add myself, will add maciekpytel to the same PR.

@Priyankasaggu11929
Copy link
Member Author

Hello @gjtempleton, I've added you and @MaciekPytel to kubernetes-sigs org as part of this PR itself, so org membership requirements are fine now. No need for separate PRs.

@gjtempleton gjtempleton mentioned this pull request Nov 23, 2023
Closed
@Priyankasaggu11929
Copy link
Member Author

@MadhavJivrajani, @palnabarun need review/approval. Thanks!

jonathan-innis
jonathan-innis reviewed Nov 24, 2023
View reviewed changes
config/kubernetes-sigs/sig-autoscaling/teams.yaml
@@ -0,0 +1,35 @@
teams:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to create a team for the reviewers or is that solely handled by the OWNERS_ALIASES file that's in kubernetes-sigs/karpenter?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, creating a team would be fine.

Who all you need to be added to the reviewers team? And with what level of access (read is enough?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read should be enough. Just talking about reviewer-level. This is the list of users from the proposed PR: https://github.com/jonathan-innis/karpenter-core/blob/add-new-member-approvers/OWNERS_ALIASES#L14

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added karpenter-reviewers team

palnabarun
palnabarun approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, Priyankasaggu11929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Priyankasaggu11929,palnabarun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bb0a997 into kubernetes:main Nov 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis left review comments

@palnabarun palnabarun palnabarun approved these changes

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

Assignees

@palnabarun palnabarun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Priyankasaggu11929 @gjtempleton @k8s-ci-robot @palnabarun @jonathan-innis