REQUEST: Migrate aws/karpenter-core

[jonathan-innis]

New repo, staging repo, or migrate existing

Migrate existing

Is it a staging repo?

no

Requested name for new repository

karpenter

Which Organization should it reside

kubernetes-sigs

Who should have admin access?

mwielgus, maciekpytel, gjtempleton, etarn, ellistarn, jonathan-innis, tzneal, bwagner5, njtran

Who should have write access?

N/A

Who should be listed as approvers in OWNERS?

mwielgus, maciekpytel, gjtempleton, etarn, ellistarn, jonathan-innis, tzneal, bwagner5, njtran

Who should be listed in SECURITY_CONTACTS?

jonathan-innis, etarn, njtran, tzneal

What should the repo description be?

Karpenter is a Kubernetes Node Lifecycle Management Solution built for flexibility, performance, and simplicity.

What SIG and subproject does this fall under?

sig-autoscaling

Please provide references to appropriate approval for this new repo

Approval from SIG chair (@gjtempleton) after lazy consensus period here: #4258 (comment)

Awaiting approval from @mwielgus and then we have a go-ahead on this move.

Additional context for request

We're staging out a final release prior to the repo move (v0.32.0) which should be completed today or tomorrow. After that point, we have the forward momentum to begin removing the repo to have the next release (v0.33.0) be released from the kubernetes-sigs organization.

We'd like to see the OWNERS, OWNERS_ALIASES, and SECURITY_CONTACTS.md files look like this

OWNERS file

# See the OWNERS docs: https://git.k8s.io/community/contributors/guide/owners.md

approvers:
  - sig-autoscaling-leads
  - karpenter-maintainers

reviewers:
  - karpenter-reviewers

OWNERS_ALIASES file

# See the OWNERS_ALIASES docs: https://git.k8s.io/community/contributors/guide/owners.md#owners_aliases

aliases:
  sig-autoscaling-leads:
    - mwielgus
    - maciekpytel
    - gjtempleton
  karpenter-maintainers:
    - ellistarn
    - jonathan-innis
    - tzneal
    - bwagner5
    - njtran
  karpenter-reviewers:
    - jackfrancis
    - tallaxes

SECURITY_CONTACTS file

# Defined below are the security contacts for this repo.
#
# They are the contact point for the Security Response Committee to reach out
# to for triaging and handling of incoming issues.
#
# The below names agree to abide by the
# [Embargo Policy](https://git.k8s.io/security/private-distributors-list.md#embargo-policy)
# and will be removed and replaced if they violate that agreement.
#
# DO NOT REPORT SECURITY VULNERABILITIES DIRECTLY TO THESE NAMES, FOLLOW THE
# INSTRUCTIONS AT https://kubernetes.io/security/

jonathan-innis
ellistarn
njtran
tzneal

[jonathan-innis]

Waiting on @mwielgus on this issue or on #4258 to provide approval and then we should have the go-ahead to migrate the repo from the AWS org

[jonathan-innis]

Haven't heard any word from @mwielgus after the lazy consensus period expired. From our WG meetings, we had approval from all the SIG Autoscaling chairs to move forward on the repo migration. @gjtempleton Any word on if we should wait for @mwielgus to respond to the original request or just move forward with a lgtm, assuming lazy consensus and taking the verbal agreement in the WG meeting to mean that we can proceed?

[gjtempleton]

Given the past discussions in the WG and the expiry of the lazy consensus period with no objections, happy to give this the SIG Leadership stamp of approval.

[mwielgus]

LGTM :)

[jonathan-innis]

/sig autoscaling

[jonathan-innis]

@mrbobbytables @nikhita I see y'all are the primary reviewers. Looks like we got sign-off from the SIG. What do we need to do here to get traction around the request?

[Priyankasaggu11929]

We've +1s from sig-autoscaling leads. Thanks!

I'll go ahead with creating the repo migration.

/assign

[jonathan-innis]

Hey @sergkondr @abeer-stripe @shikai93 @gfcroft @lucass4 @wkaczynski @spring1843 @engedaam @njtran! Y'all are currently on the list of contributors to aws/karpenter-core who are being flagged as having not signed the CNCF CLA. Checking in to see if y'all can sign the CLA. For now, we're going to place you in a NOTICE file that denotes that you have contributed to the repo but haven't signed the CLA. We can drop you from the NOTICE once it's signed. TIA

[Priyankasaggu11929]

Following the kubernetes-repositories.md#rules-for-donated-repositories:

• A NOTICE file has been added to meet the following requirement (link):

All contributors must have signed the CNCF Individual CLA or CNCF Corporate CLA

If (a) contributor(s) have not signed the CLA and could not be reached, a NOTICE file should be added referencing section 7 of the CLA with a list of the developers who could not be reached

• LICENSE file present, as per https://github.com/kubernetes/kubernetes-template-project/blob/main/LICENSE

---

Following needs to be added post-transfer (ideally occur shortly thereafter) cc: @jonathan-innis

• Boilerplate text across all files should attribute copyright as follows: "Copyright <Project Authors>" if no CLA was in place prior to donation
• Additions of the standard Kubernetes header to code created by the contributors can occur post-transfer, but should ideally occur shortly thereafter.
• add RELEASE.md file from https://github.com/kubernetes/kubernetes-template-project

---

We have to use an intermediary org (https://github.com/kubernetes-purgatory) to transfer the repo.
Received confirmation from @jonathan-innis to invite https://github.com/neilzhao-aws to help with the transfer.
Invite sent, waiting to accept, to provide Repo Creation permission to enable transfer of https://github.com/aws/karpenter-core/

[Priyankasaggu11929]

Repo has been migrated to kubernetes-sigs org - https://github.com/kubernetes-sigs/karpenter

PR to to add new repo to k/community sigs.yaml is merged - kubernetes/community#7624

I'll work on adding GitHub teams for the new repo my tommorow morning.

[Priyankasaggu11929]

PR to add GitHub teams: #4602

[jonathan-innis]

Boilerplate text across all files should attribute copyright as follows

@Priyankasaggu11929 A clarifying point on the first two tasks that are mentioned in that tasklist above. It's not clear to me if we should use "Copyright 2023 The Kubernetes Authors" on all files now or if there should be subset of files that need some other copyright attribution. Can you help clarify here?

[Priyankasaggu11929]

@jonathan-innis

• Boilerplate text across all files should attribute copyright as follows: "Copyright <Project Authors>" if no CLA was in place prior to donation

This is to be added to all files where folks who're in NOTICE file (who haven't signed CNCF CLA) has contributed.

Copyright <John Doe john-doe> 

@mrbobbytables, can you please confirm if this will be in addition to the kubernetes copyright header?

• Additions of the standard Kubernetes header to code created by the contributors can occur post-transfer, but should ideally occur shortly thereafter.

^ one is to add the standard kubernetes copyright header text to all code files - https://git.k8s.io/kubernetes/hack/boilerplate/boilerplate.go.txt

[jonathan-innis]

This is to be added to all files where folks who're in NOTICE file (who haven't signed CNCF CLA) has contributed

@Priyankasaggu11929 @mrbobbytables If there are no current contributions that that person has (by looking at the blame file), are we able to remove them from the NOTICE file and not add copyright attribution for them? Or is it if the user has touched the file at all?

[jonathan-innis]

@Priyankasaggu11929 @mrbobbytables Bump on this again. Need some confirmation around how to proceed here with the license files to make sure we are up-to-date with the requirements and can work towards closing this issue out.

[mrbobbytables]

@jonathan-innis and I chatted out of band. Looking at prior art across the project, I could not find a project that had both a NOTICE file and copyright header with multiple authors. For now I've given them to go ahead to skip that part of migration and will take it back to the github admins to discuss.

[jonathan-innis]

@Priyankasaggu11929 @mrbobbytables The license change should be in now. The only remaining item that's left off of this list is:

• add RELEASE.md file from https://github.com/kubernetes/kubernetes-template-project

[jonathan-innis]

Just knocked out the last item! I think we are good here! Thanks @Priyankasaggu11929 and @mrbobbytables for all of the support!