Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample repo for cloud-provider creation #314

Closed
cheftako opened this issue Dec 19, 2018 · 11 comments
Closed

Sample repo for cloud-provider creation #314

cheftako opened this issue Dec 19, 2018 · 11 comments
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository

Comments

@cheftako
Copy link
Member

New Repo, Staging Repo, or migrate existing

new repository

Requested name for new repository

cloud-provider-sample

Which Organization should it reside

sig-cloud-provider

If not a staging repo, who should have admin access

@cheftako @andrewsykim @mcrute

If not a staging repo, who should have write access

@cheftako @andrewsykim @mcrute

If a new repo, who should be listed as approvers in OWNERS

@cheftako @andrewsykim @mcrute

If a new repo, who should be listed in SECURITY_CONTACTS

@cheftako @andrewsykim @mcrute

What should the repo description be

Sample of how to build a cloud provider repo.
This will build a Kubernetes image which deploys on bare metal.
It uses the fake cloud provider.
It consumes the K8s/K8s build artifact and adds to it the Cloud Controller Manager and CSI Daemon Set.

What SIG and subproject does this fall under in sigs.yaml

This is a sample of how to create a cloud provider repo for sig-cloudprovider

Approvals

Conversation with @andrewsykim and @mcrute

Authoritative requirements are here: https://git.k8s.io/community/github-management/kubernetes-repositories.md

  • If this is a SIG repository, then this must follow the procedure spelled out in that SIG's charter

Additional context for request

This was discussed in the KubeCon Seattle SIG meeting.

/area github-repo

@k8s-ci-robot k8s-ci-robot added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Dec 19, 2018
@andrewsykim
Copy link
Member

+1 thanks @cheftako

@mcrute
Copy link

mcrute commented Dec 19, 2018

+1

@calebamiles
Copy link
Contributor

/assign

@fedebongio
Copy link

/cc

calebamiles added a commit to kubernetes/cloud-provider-sample that referenced this issue Dec 22, 2018
@calebamiles
Copy link
Contributor

done. please update sigs.yaml with the new repository

@calebamiles
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@calebamiles: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andrewsykim
Copy link
Member

Thanks Caleb! PR for sigs.yaml kubernetes/community#3051

@spiffxp
Copy link
Member

spiffxp commented Dec 26, 2018

Why isn't this a kubernetes-sigs repo? Why didn't this get approved through sig-arch?

https://github.com/kubernetes/community/blob/master/github-management/kubernetes-repositories.md#rules-1

@andrewsykim
Copy link
Member

@spiffxp we already went through sig-arch approvals for kubernetes/cloud-provider-* repos (see https://groups.google.com/forum/#!topic/kubernetes-sig-architecture/soeIadIeMCs). It also wouldn't make sense for us to host the actual provider repos in kubernetes but host the sample repo in kubernetes-sigs. Having everything in kubernetes-sigs is something we intend to do eventually (though not urgent).

@nikhita
Copy link
Member

nikhita commented Dec 27, 2018

I came across this repo while working on kubernetes/steering#28 and have created a PR to add template files (LICENSE, CONTRIBUTING.md, README.md, code-of-conduct.md): kubernetes/cloud-provider-sample#1.

The README description is based on the description provided here. PTAL. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository
Projects
None yet
Development

No branches or pull requests

8 participants