Add template files #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
This was referenced Dec 27, 2018
|
Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mcrute The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
cheftako
reviewed
Dec 27, 2018
| @@ -0,0 +1,18 @@ | |||
| # cloud-provider-sample | |||
|
|
|||
| This is a sample of how to build a cloud provider repo. This will build a Kubernetes image which deploys on bare metal. | |||
There was a problem hiding this comment.
This is the intent. I think it would be good to warn people its a WIP until its actually working.
There was a problem hiding this comment.
Oh good point! I have added a note. 👍
nikhita
force-pushed
the
template-files
branch
from
55bc201 to
ac0a138
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks @nikhita |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: kubernetes/steering#28 (for CONTRIBUTING.md) and kubernetes/community#3053 (for CoC) and kubernetes/steering#57 (comment) (for LICENSE)
The content is as per https://github.com/kubernetes/kubernetes-template-project
/assign @andrewsykim @cheftako @mcrute