Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double addon pod wait time to avoid errors on slow pulls #9515

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Double addon pod wait time to avoid errors on slow pulls #9515

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20d1645
Wait up to 5 minutes for addon pods, improve error message
tstromberg Oct 21, 2020
e2fdc07
Use 6 minutes, to use the philosophy of doubling timeouts you hit
tstromberg Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/addons/addons.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,9 +353,10 @@ func verifyAddonStatusInternal(cc *config.ClusterConfig, name string, val string
return errors.Wrapf(err, "get kube-client to validate %s addon: %v", name, err)
}

err = kapi.WaitForPods(client, ns, label, time.Minute*3)
// This timeout includes image pull time, which can take a few minutes. 3 is not enough.
err = kapi.WaitForPods(client, ns, label, time.Minute*6)
if err != nil {
return errors.Wrapf(err, "verifying %s addon pods : %v", name, err)
return errors.Wrapf(err, "waiting for %s pods", label)
}

}
Expand Down