Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double addon pod wait time to avoid errors on slow pulls #9515

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Oct 21, 2020

Fixes #9514

"If a unit seems too weak, don’t lower its cost by 5%; instead, double its strength. If players feel overwhelmed by too many upgrades, try removing half of them. In the original Civilization, the gameplay kept slowing down to a painful crawl, which Sid solved by shrinking the map in half. The point is not that the new values are likely to be correct; the goal is to stake out more design territory with each successive iteration."

— Analysis: Sid Meier's Key Design Lessons

Old behavior

If an addon takes >3 minutes to pull and start, emit error:

❌ Exiting due to MK_ENABLE: run callbacks: running callbacks: [verifying registry addon pods : timed out waiting for the condition: timed out waiting for the condition]

New behavior

If an addon takes >6 minutes to pull and start, emit error:

❌ Exiting due to MK_ENABLE: run callbacks: running callbacks: [waiting for kubernetes.io/minikube-addons=registry pods: timed out waiting for the condition: timed out]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 21, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 21, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9515): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9515/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9515/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9515): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9515/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9515/minikube: exec format error

@tstromberg
Copy link
Contributor Author

/ok-to-test

@tstromberg tstromberg changed the title Wait up to 5 minutes for addon pods, improve error message Double the time we wait for pods to appear, to avoid errors on slow pulls Oct 21, 2020
@tstromberg tstromberg changed the title Double the time we wait for pods to appear, to avoid errors on slow pulls Double the addon pod wait time, to avoid errors on slow pulls Oct 21, 2020
@tstromberg tstromberg changed the title Double the addon pod wait time, to avoid errors on slow pulls Double addon pod wait time to avoid errors on slow pulls Oct 21, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9515): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9515/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9515/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9515): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9515/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9515/minikube: exec format error

@medyagh medyagh merged commit a61e091 into kubernetes:master Oct 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube addons enable registry doesn't work - timeout
4 participants