-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double addon pod wait time to avoid errors on slow pulls #9515
Conversation
/ok-to-test |
kvm2 Driver |
/ok-to-test |
kvm2 Driver |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #9514
"If a unit seems too weak, don’t lower its cost by 5%; instead, double its strength. If players feel overwhelmed by too many upgrades, try removing half of them. In the original Civilization, the gameplay kept slowing down to a painful crawl, which Sid solved by shrinking the map in half. The point is not that the new values are likely to be correct; the goal is to stake out more design territory with each successive iteration."
— Analysis: Sid Meier's Key Design Lessons
Old behavior
If an addon takes >3 minutes to pull and start, emit error:
❌ Exiting due to MK_ENABLE: run callbacks: running callbacks: [verifying registry addon pods : timed out waiting for the condition: timed out waiting for the condition]
New behavior
If an addon takes >6 minutes to pull and start, emit error:
❌ Exiting due to MK_ENABLE: run callbacks: running callbacks: [waiting for kubernetes.io/minikube-addons=registry pods: timed out waiting for the condition: timed out]