-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo Fix #65247
Typo Fix #65247
Conversation
gambol99
commented
Jun 19, 2018
- nothing much here just a typo fix found when copying and pasting into a kops #PR5349
- nothing much here just a typo fix found when copied and pasting into a kops PR kubernetes/kops#5349
@gambol99: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/release-note-none |
/assign @thockin |
/approve |
/kind cleanup Looks like it wasn't approved because bot expects |
The comment says approved but looks like the label didn’t get added. Maybe lack of tokens? @thockin can you approve again? |
We got rid of the approve no-issue command (thankfully) :D |
/retest
…On Fri, Jun 29, 2018 at 2:58 PM k8s-ci-robot ***@***.***> wrote:
@gambol99 <https://github.com/gambol99>: The following test *failed*, say
/retest to rerun them all:
Test name Commit Details Rerun command
pull-kubernetes-e2e-gce e9ed243
<e9ed243>
link
<https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/65247/pull-kubernetes-e2e-gce/42591/> /test
pull-kubernetes-e2e-gce
Full PR test history <https://k8s-gubernator.appspot.com/pr/65247>. Your
PR dashboard <https://k8s-gubernator.appspot.com/pr/gambol99>. Please
help us cut down on flakes by linking to
<https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests>
an open issue
<https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open> when
you hit one in your PR.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#65247 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APXA0IlpgsWUAOr2VFWDU0gYSsOI5MxIks5uBfNGgaJpZM4UuWHG>
.
|
/test pull-kubernetes-integration |
ping @thockin for approval (again 😕) |
/retest |
/approve |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gambol99, thockin, wgliang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hiya .. i'm gonna close this PR ... I don't mean it discourteously but the carbon foot print alone to get this merged is becoming somewhat farcical |
@gambol99 sorry about that! Now that the PR is approved + lgtm'ed again it should get merged automatically. The last comment that you see is from the merge bot. I think the tests will run once again by the submit queue too but it should be fairly quick now. If it doesn't merges soon, I'll try to carry this change in another commit and close this PR myself. 👍 /reopen |
@nikhita: you can't re-open an issue/PR unless you authored it or you are assigned to it. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/reopen |
/test all [submit-queue is verifying that this PR is safe to merge] |
@gambol99: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Automatic merge from submit-queue (batch tested with PRs 65247, 63633, 67425). If you want to cherry-pick this change to another branch, please follow the instructions here. |