Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo Fix #65247

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Typo Fix #65247

merged 1 commit into from
Aug 23, 2018

Conversation

gambol99
Copy link
Contributor

  • nothing much here just a typo fix found when copying and pasting into a kops #PR5349

- nothing much here just a typo fix found when copied and pasting into a kops PR kubernetes/kops#5349
@k8s-ci-robot
Copy link
Contributor

@gambol99: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 19, 2018
@gambol99 gambol99 changed the title Type Fix Typo Fix Jun 19, 2018
@wgliang
Copy link
Contributor

wgliang commented Jun 20, 2018

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2018
@nikhita
Copy link
Member

nikhita commented Jun 20, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 20, 2018
@nikhita
Copy link
Member

nikhita commented Jun 20, 2018

/assign @thockin
for approval

@thockin
Copy link
Member

thockin commented Jun 21, 2018

/approve

@php-coder
Copy link
Contributor

/kind cleanup

Looks like it wasn't approved because bot expects /approve no-issue command.

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 21, 2018
@nikhita
Copy link
Member

nikhita commented Jun 21, 2018

The comment says approved but looks like the label didn’t get added. Maybe lack of tokens?

@thockin can you approve again?

@nikhita
Copy link
Member

nikhita commented Jun 21, 2018

Looks like it wasn't approved because bot expects /approve no-issue command.

We got rid of the approve no-issue command (thankfully) :D

@nikhita
Copy link
Member

nikhita commented Jun 29, 2018 via email

@KashifSaadat
Copy link
Contributor

/test pull-kubernetes-integration

@nikhita
Copy link
Member

nikhita commented Jul 10, 2018

ping @thockin for approval (again 😕)

@nikhita
Copy link
Member

nikhita commented Aug 13, 2018

/retest

@thockin
Copy link
Member

thockin commented Aug 23, 2018

/approve

@thockin
Copy link
Member

thockin commented Aug 23, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gambol99, thockin, wgliang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2018
@gambol99
Copy link
Contributor Author

hiya .. i'm gonna close this PR ... I don't mean it discourteously but the carbon foot print alone to get this merged is becoming somewhat farcical

@gambol99 gambol99 closed this Aug 23, 2018
@nikhita
Copy link
Member

nikhita commented Aug 23, 2018

hiya .. i'm gonna close this PR ... I don't mean it discourteously but the carbon foot print alone to get this merged is becoming somewhat farcical

@gambol99 sorry about that!

Now that the PR is approved + lgtm'ed again it should get merged automatically. The last comment that you see is from the merge bot. I think the tests will run once again by the submit queue too but it should be fairly quick now.

If it doesn't merges soon, I'll try to carry this change in another commit and close this PR myself. 👍

/reopen

@k8s-ci-robot
Copy link
Contributor

@nikhita: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

hiya .. i'm gonna close this PR ... I don't mean it discourteously but the carbon foot print alone to get this merged is becoming somewhat farcical

@gambol99 sorry about that!

Now that the PR is approved + lgtm'ed again it should get merged automatically. The last comment that you see is from the merge bot. I think the tests will run once again by the submit queue too but it should be fairly quick now.

If it doesn't merges soon, I'll try to carry this change in another commit and close this PR myself. 👍

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita
Copy link
Member

nikhita commented Aug 23, 2018

/assign

@nikhita
Copy link
Member

nikhita commented Aug 23, 2018

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Aug 23, 2018
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Aug 23, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

@gambol99: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce e9ed243 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 65247, 63633, 67425). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 93accdb into kubernetes:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants